[webkit-changes] [WebKit/WebKit] 217f2e: [GStreamer][MSE][Debug] Flaky crashes during GC of...

Philippe Normand noreply at github.com
Mon Nov 20 01:47:16 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 217f2eada7bec2982edbdf5a472bf2430867e7f6
      https://github.com/WebKit/WebKit/commit/217f2eada7bec2982edbdf5a472bf2430867e7f6
  Author: Philippe Normand <philn at igalia.com>
  Date:   2023-11-20 (Mon, 20 Nov 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp
    M Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.h

  Log Message:
  -----------
  [GStreamer][MSE][Debug] Flaky crashes during GC of SourceBufferPrivate
https://bugs.webkit.org/show_bug.cgi?id=265105

Reviewed by Xabier Rodriguez-Calvar.

Settle a result on the appendPromise before disposal, otherwise we hit an ASSERT(!isNothing()) in
the NativePromise destructor.

* Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp:
(WebCore::SourceBufferPrivateGStreamer::~SourceBufferPrivateGStreamer):
* Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.h:

Canonical link: https://commits.webkit.org/270968@main




More information about the webkit-changes mailing list