[webkit-changes] [WebKit/WebKit] 6656a3: [GStreamer][WebCodecs][Debug] ASSERTs in video enc...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6656a3ab02122919cbd5b37b73d026f3b2652f08
      https://github.com/WebKit/WebKit/commit/6656a3ab02122919cbd5b37b73d026f3b2652f08
  Author: Philippe Normand <philn at igalia.com>
  Date:   2023-11-20 (Mon, 20 Nov 2023)

  Changed paths:
    M Source/WebCore/platform/audio/gstreamer/AudioEncoderGStreamer.cpp
    M Source/WebCore/platform/audio/gstreamer/AudioEncoderGStreamer.h
    M Source/WebCore/platform/graphics/gstreamer/VideoEncoderGStreamer.cpp
    M Source/WebCore/platform/graphics/gstreamer/VideoEncoderGStreamer.h

  Log Message:
  -----------
  [GStreamer][WebCodecs][Debug] ASSERTs in video encoder
https://bugs.webkit.org/show_bug.cgi?id=264935
<rdar://problem/118559880>

Reviewed by Xabier Rodriguez-Calvar.

Refactor encoders to avoid storing the codecName string in the internal encoders. This should
hopefully prevent any String-related crash during destruction.

* Source/WebCore/platform/audio/gstreamer/AudioEncoderGStreamer.cpp:
(WebCore::GStreamerInternalAudioEncoder::create):
(WebCore::GStreamerAudioEncoder::create):
(WebCore::GStreamerAudioEncoder::GStreamerAudioEncoder):
(WebCore::GStreamerInternalAudioEncoder::GStreamerInternalAudioEncoder):
(WebCore::GStreamerInternalAudioEncoder::initialize):
(WebCore::GStreamerAudioEncoder::initialize): Deleted.
* Source/WebCore/platform/audio/gstreamer/AudioEncoderGStreamer.h:
* Source/WebCore/platform/graphics/gstreamer/VideoEncoderGStreamer.cpp:
(WebCore::GStreamerInternalVideoEncoder::create):
(WebCore::GStreamerVideoEncoder::create):
(WebCore::GStreamerVideoEncoder::GStreamerVideoEncoder):
(WebCore::GStreamerInternalVideoEncoder::GStreamerInternalVideoEncoder):
(WebCore::GStreamerInternalVideoEncoder::initialize):
(WebCore::GStreamerVideoEncoder::initialize): Deleted.
* Source/WebCore/platform/graphics/gstreamer/VideoEncoderGStreamer.h:

Canonical link: https://commits.webkit.org/270966@main