[webkit-changes] [WebKit/WebKit] ea1e46: Clean up ResourceResponseBase.h

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ea1e46c69adf276a5ef275623dfd32980ebb3670
      https://github.com/WebKit/WebKit/commit/ea1e46c69adf276a5ef275623dfd32980ebb3670
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2023-11-18 (Sat, 18 Nov 2023)

  Changed paths:
    M Source/WebCore/platform/WebCorePersistentCoders.cpp
    M Source/WebCore/platform/network/ResourceResponseBase.cpp
    M Source/WebCore/platform/network/ResourceResponseBase.h
    M Source/WebCore/workers/service/background-fetch/BackgroundFetch.cpp
    M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in

  Log Message:
  -----------
  Clean up ResourceResponseBase.h
https://bugs.webkit.org/show_bug.cgi?id=265051
rdar://118572034

Reviewed by Chris Dumez.

We had two structs that contained the exact same members,
ResourceResponseBaseCrossThreadData and ResponseData.  I made them be one
struct named ResourceResponseData.  ResourceResponseData::isolatedCopy
still safely calls isolatedCopy like it did before.  Also, I move the
encoding/decoding code from the header to
Coder<WebCore::ResourceResponse>::encodeForPersistence and
Coder<WebCore::ResourceResponse>::decodeForPersistence without changing
the order of the persistently-serialized members.

* Source/WebCore/platform/WebCorePersistentCoders.cpp:
(WTF::Persistence::Coder<WebCore::ResourceResponse>::encodeForPersistence):
(WTF::Persistence::Coder<WebCore::ResourceResponse>::decodeForPersistence):
* Source/WebCore/platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::ResourceResponseBase):
(WebCore::m_mimeType):
(WebCore::m_textEncodingName):
(WebCore::m_httpStatusText):
(WebCore::m_httpVersion):
(WebCore::m_httpHeaderFields):
(WebCore::m_networkLoadMetrics):
(WebCore::m_type):
(WebCore::ResourceResponseData::isolatedCopy const):
(WebCore::ResourceResponseBase::crossThreadData const):
(WebCore::ResourceResponseBase::getResponseData const):
(WTF::Persistence::Coder<WebCore::ResourceResponseData>::encodeForPersistence):
(WTF::Persistence::Coder<WebCore::ResourceResponseData>::decodeForPersistence):
(WebCore::ResourceResponseBaseCrossThreadData::isolatedCopy const): Deleted.
(WTF::Persistence::Coder<WebCore::ResourceResponseBase::CrossThreadData>::encodeForPersistence): Deleted.
(WTF::Persistence::Coder<WebCore::ResourceResponseBase::CrossThreadData>::decodeForPersistence): Deleted.
* Source/WebCore/platform/network/ResourceResponseBase.h:
(WebCore::ResourceResponseData::ResourceResponseData):
(WebCore::ResourceResponseBaseCrossThreadData::ResourceResponseBaseCrossThreadData): Deleted.
(WebCore::ResourceResponseBase::encode const): Deleted.
(WebCore::ResourceResponseBase::decode): Deleted.
* Source/WebCore/workers/service/background-fetch/BackgroundFetch.cpp:
(WebCore::BackgroundFetch::createFromStore):
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:

Canonical link: https://commits.webkit.org/270946@main