[webkit-changes] [WebKit/WebKit] 15b788: [WebM] MediaPlayerPrivateWebM can never enter in e...

Jean-Yves Avenard noreply at github.com
Sat Nov 18 04:29:18 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 15b788c586a8c43ab2505a0224ec081097f659ec
      https://github.com/WebKit/WebKit/commit/15b788c586a8c43ab2505a0224ec081097f659ec
  Author: Jean-Yves Avenard <jya at apple.com>
  Date:   2023-11-18 (Sat, 18 Nov 2023)

  Changed paths:
    A LayoutTests/media/content/opus_variable_witherror.webm
    A LayoutTests/media/media-webm-opus-error-expected.txt
    A LayoutTests/media/media-webm-opus-error.html
    M LayoutTests/platform/glib/TestExpectations
    M LayoutTests/platform/mac-wk1/TestExpectations
    M Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.h
    M Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm

  Log Message:
  -----------
  [WebM] MediaPlayerPrivateWebM can never enter in error state
https://bugs.webkit.org/show_bug.cgi?id=264931
rdar://118499989

Reviewed by Youenn Fablet.

Parser return value wasn't read, therefore we couldn't detect errors.

* LayoutTests/media/content/opus_variable_witherror.webm: Added.
* LayoutTests/media/media-webm-opus-error-expected.txt: Added.
* LayoutTests/media/media-webm-opus-error.html: Added.
* LayoutTests/platform/mac-wk1/TestExpectations:
* Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.h:
* Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm:
(WebCore::MediaPlayerPrivateWebM::appendCompleted):
(WebCore::MediaPlayerPrivateWebM::append):

Canonical link: https://commits.webkit.org/270938@main




More information about the webkit-changes mailing list