[webkit-changes] [WebKit/WebKit] 1021b9: [WebM] video.buffered attribute will always be empty
Jean-Yves Avenard
noreply at github.com
Fri Nov 17 23:08:30 PST 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1021b9500accef619ee22b690c8b7ce7a8582baf
https://github.com/WebKit/WebKit/commit/1021b9500accef619ee22b690c8b7ce7a8582baf
Author: Jean-Yves Avenard <jya at apple.com>
Date: 2023-11-17 (Fri, 17 Nov 2023)
Changed paths:
A LayoutTests/media/content/short.webm
A LayoutTests/media/media-webm-opus-buffered-expected.txt
A LayoutTests/media/media-webm-opus-buffered.html
M LayoutTests/platform/mac-wk1/TestExpectations
M Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.h
M Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm
Log Message:
-----------
[WebM] video.buffered attribute will always be empty
https://bugs.webkit.org/show_bug.cgi?id=265010
rdar://118550061
Reviewed by Jer Noble.
The MediaPlayerPrivate wasnt' notified when the buffered range was set.
Fly-by fix: networkState would never go back to idle if the media element only had an audio track.
We can also remote the method resetParserState, it serves no purpose for CRABS.
* LayoutTests/media/content/short.webm: Added.
* LayoutTests/media/media-webm-opus-buffered-expected.txt: Added.
* LayoutTests/media/media-webm-opus-buffered.html: Added.
* LayoutTests/platform/mac-wk1/TestExpectations:
* Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.h:
* Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm:
(WebCore::MediaPlayerPrivateWebM::~MediaPlayerPrivateWebM):
(WebCore::MediaPlayerPrivateWebM::loadFinished):
(WebCore::MediaPlayerPrivateWebM::setBufferedRanges):
(WebCore::MediaPlayerPrivateWebM::updateDurationFromTrackBuffers):
(WebCore::MediaPlayerPrivateWebM::setNaturalSize):
(WebCore::MediaPlayerPrivateWebM::setNetworkState):
(WebCore::MediaPlayerPrivateWebM::appendCompleted):
(WebCore::MediaPlayerPrivateWebM::didParseInitializationData):
(WebCore::MediaPlayerPrivateWebM::resetParserState): Deleted.
Canonical link: https://commits.webkit.org/270931@main
More information about the webkit-changes
mailing list