[webkit-changes] [WebKit/WebKit] e98de6: [LBSE] Fix RenderSVGResourceClipper (re)painting p...

[Rob Buis]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e98de6f4b331de2ca6ea78c00b6b6d6243c78621
      https://github.com/WebKit/WebKit/commit/e98de6f4b331de2ca6ea78c00b6b6d6243c78621
  Author: Rob Buis <rbuis at igalia.com>
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
    A LayoutTests/svg/repaint/clip-path-object-bounding-box-expected.txt
    A LayoutTests/svg/repaint/clip-path-object-bounding-box-shrink-expected.txt
    A LayoutTests/svg/repaint/clip-path-object-bounding-box-shrink.html
    A LayoutTests/svg/repaint/clip-path-object-bounding-box-transformed-expected.txt
    A LayoutTests/svg/repaint/clip-path-object-bounding-box-transformed.html
    A LayoutTests/svg/repaint/clip-path-object-bounding-box.html
    A LayoutTests/svg/repaint/clip-path-user-space-on-use-expected.txt
    A LayoutTests/svg/repaint/clip-path-user-space-on-use-shrink-expected.txt
    A LayoutTests/svg/repaint/clip-path-user-space-on-use-shrink.html
    A LayoutTests/svg/repaint/clip-path-user-space-on-use-transformed-expected.txt
    A LayoutTests/svg/repaint/clip-path-user-space-on-use-transformed.html
    A LayoutTests/svg/repaint/clip-path-user-space-on-use.html
    M Source/WebCore/rendering/RenderElement.cpp
    M Source/WebCore/rendering/RenderLayer.h
    M Source/WebCore/rendering/RenderLayerInlines.h
    M Source/WebCore/rendering/svg/RenderSVGResourceClipper.cpp
    M Source/WebCore/svg/SVGClipPathElement.cpp
    M Source/WebCore/svg/SVGClipPathElement.h

  Log Message:
  -----------
  [LBSE] Fix RenderSVGResourceClipper (re)painting problems
https://bugs.webkit.org/show_bug.cgi?id=264946

Reviewed by Nikolas Zimmermann.

The logic in RenderSVGResourceClipper::resourceBoundingBox does not take
the actual clip content rectangle into account, use the legacy solution which does.

Also stop repainting SVG resources by adjusting RenderElement::isInsideEntirelyHiddenLayer.

This PR also adds repaint tests that verify repaint rectangles after changing clipping content.

* LayoutTests/svg/repaint/clip-path-object-bounding-box-expected.txt: Added.
* LayoutTests/svg/repaint/clip-path-object-bounding-box-shrink-expected.txt: Added.
* LayoutTests/svg/repaint/clip-path-object-bounding-box-shrink.html: Added.
* LayoutTests/svg/repaint/clip-path-object-bounding-box-transformed-expected.txt: Added.
* LayoutTests/svg/repaint/clip-path-object-bounding-box-transformed.html: Added.
* LayoutTests/svg/repaint/clip-path-object-bounding-box.html: Added.
* LayoutTests/svg/repaint/clip-path-user-space-on-use-expected.txt: Added.
* LayoutTests/svg/repaint/clip-path-user-space-on-use-shrink-expected.txt: Added.
* LayoutTests/svg/repaint/clip-path-user-space-on-use-shrink.html: Added.
* LayoutTests/svg/repaint/clip-path-user-space-on-use-transformed-expected.txt: Added.
* LayoutTests/svg/repaint/clip-path-user-space-on-use-transformed.html: Added.
* LayoutTests/svg/repaint/clip-path-user-space-on-use.html: Added.
* Source/WebCore/rendering/RenderElement.cpp:
(WebCore::RenderElement::isInsideEntirelyHiddenLayer const):
* Source/WebCore/rendering/RenderLayer.h:
* Source/WebCore/rendering/RenderLayerInlines.h:
(WebCore::RenderLayer::enclosingSVGHiddenOrResourceContainer const):
* Source/WebCore/rendering/svg/RenderSVGResourceClipper.cpp:
(WebCore::RenderSVGResourceClipper::resourceBoundingBox):
* Source/WebCore/svg/SVGClipPathElement.cpp:
(WebCore::SVGClipPathElement::calculateClipContentRepaintRect):
* Source/WebCore/svg/SVGClipPathElement.h:

Canonical link: https://commits.webkit.org/270913@main