[webkit-changes] [WebKit/WebKit] 4dacd4: Regression(267645 at main) ~3MB increase in binary size

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4dacd4adab9471bc6dfb8ce2c0a090a03cce1d52
      https://github.com/WebKit/WebKit/commit/4dacd4adab9471bc6dfb8ce2c0a090a03cce1d52
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
    M Source/JavaScriptCore/assembler/AbstractMacroAssembler.h
    M Source/JavaScriptCore/b3/B3Origin.h
    M Source/JavaScriptCore/b3/B3Type.h
    M Source/JavaScriptCore/b3/air/AirTmp.h
    M Source/JavaScriptCore/bytecode/ArithProfile.h
    M Source/JavaScriptCore/bytecode/CallVariant.h
    M Source/JavaScriptCore/bytecode/CodeBlockHash.h
    M Source/JavaScriptCore/bytecode/VirtualRegister.h
    M Source/JavaScriptCore/debugger/DebuggerScope.h
    M Source/JavaScriptCore/dfg/DFGAbstractHeap.h
    M Source/JavaScriptCore/dfg/DFGAbstractValueClobberEpoch.h
    M Source/JavaScriptCore/dfg/DFGEdge.h
    M Source/JavaScriptCore/dfg/DFGEpoch.h
    M Source/JavaScriptCore/dfg/DFGNodeFlowProjection.h
    M Source/JavaScriptCore/dfg/DFGRegisteredStructure.h
    M Source/JavaScriptCore/heap/Allocator.h
    M Source/JavaScriptCore/interpreter/CallFrame.h
    M Source/JavaScriptCore/jit/GPRInfo.h
    M Source/JavaScriptCore/jit/Reg.h
    M Source/JavaScriptCore/parser/SourceCodeKey.h
    M Source/JavaScriptCore/parser/VariableEnvironment.h
    M Source/JavaScriptCore/profiler/ProfilerUID.h
    M Source/JavaScriptCore/runtime/GenericOffset.h
    M Source/JavaScriptCore/runtime/ISO8601.h
    M Source/JavaScriptCore/runtime/JSScope.h
    M Source/JavaScriptCore/runtime/PageCount.h
    M Source/JavaScriptCore/runtime/StructureID.h
    M Source/JavaScriptCore/runtime/StructureTransitionTable.h

  Log Message:
  -----------
  Regression(267645 at main) ~3MB increase in binary size
https://bugs.webkit.org/show_bug.cgi?id=264896
rdar://118490755

Reviewed by Brent Fulgham.

Pass comparison operands by const reference instead of by value, as
recommended by the clang team. This should generate code more similar
to the one before 267645 at main.

* Source/JavaScriptCore/assembler/AbstractMacroAssembler.h:
* Source/JavaScriptCore/b3/B3Origin.h:
* Source/JavaScriptCore/b3/B3Type.h:
* Source/JavaScriptCore/b3/air/AirTmp.h:
* Source/JavaScriptCore/bytecode/ArithProfile.h:
* Source/JavaScriptCore/bytecode/CallVariant.h:
* Source/JavaScriptCore/bytecode/CodeBlockHash.h:
* Source/JavaScriptCore/bytecode/VirtualRegister.h:
* Source/JavaScriptCore/debugger/DebuggerScope.h:
* Source/JavaScriptCore/dfg/DFGAbstractHeap.h:
* Source/JavaScriptCore/dfg/DFGAbstractValueClobberEpoch.h:
* Source/JavaScriptCore/dfg/DFGEdge.h:
* Source/JavaScriptCore/dfg/DFGEpoch.h:
* Source/JavaScriptCore/dfg/DFGNodeFlowProjection.h:
* Source/JavaScriptCore/dfg/DFGRegisteredStructure.h:
* Source/JavaScriptCore/heap/Allocator.h:
* Source/JavaScriptCore/interpreter/CallFrame.h:
* Source/JavaScriptCore/jit/GPRInfo.h:
* Source/JavaScriptCore/jit/Reg.h:
* Source/JavaScriptCore/parser/SourceCodeKey.h:
* Source/JavaScriptCore/parser/VariableEnvironment.h:
* Source/JavaScriptCore/profiler/ProfilerUID.h:
* Source/JavaScriptCore/runtime/GenericOffset.h:
* Source/JavaScriptCore/runtime/ISO8601.h:
* Source/JavaScriptCore/runtime/JSScope.h:
* Source/JavaScriptCore/runtime/PageCount.h:
* Source/JavaScriptCore/runtime/StructureID.h:
* Source/JavaScriptCore/runtime/StructureTransitionTable.h:

Canonical link: https://commits.webkit.org/270891@main