[webkit-changes] [WebKit/WebKit] ce5a85: [UnifiedPDF] PDFPluginBase should send cursor upda...

Abrar Rahman Protyasha noreply at github.com
Thu Nov 16 20:57:33 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ce5a85abac3927874650474cd432d10cbd3ca083
      https://github.com/WebKit/WebKit/commit/ce5a85abac3927874650474cd432d10cbd3ca083
  Author: Abrar Rahman Protyasha <a_protyasha at apple.com>
  Date:   2023-11-16 (Thu, 16 Nov 2023)

  Changed paths:
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm

  Log Message:
  -----------
  [UnifiedPDF] PDFPluginBase should send cursor updates to the web page
https://bugs.webkit.org/show_bug.cgi?id=264913
rdar://118483364

Reviewed by Tim Horton.

In preparation to get cursor updates working for `UnifiedPDFPlugin`, we
should move `PDFPlugin::notifyCursorChanged` up into the `PDFPluginBase`
structure. We should be doing the same (trivial) amount of work for both
PDF plugin types to send cursor updates to the web page.

* Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:
(toWebCoreCursorType):
(-[WKPDFLayerControllerDelegate setMouseCursor:]):
(WebKit::PDFPlugin::notifySelectionChanged):
(WebKit::coreCursor): Deleted.
(WebKit::PDFPlugin::notifyCursorChanged): Deleted.
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h:
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm:
(WebKit::PDFPluginBase::notifyCursorChanged):

Canonical link: https://commits.webkit.org/270863@main




More information about the webkit-changes mailing list