[webkit-changes] [WebKit/WebKit] 029643: Cleanup pathFromGraphicsElement

Ryosuke Niwa noreply at github.com
Thu Nov 16 15:49:35 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0296432a0f5167d0ece4e378c50b85bfa2cc82ce
      https://github.com/WebKit/WebKit/commit/0296432a0f5167d0ece4e378c50b85bfa2cc82ce
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2023-11-16 (Thu, 16 Nov 2023)

  Changed paths:
    M Source/WebCore/rendering/PathOperation.cpp
    M Source/WebCore/rendering/svg/RenderSVGModelObject.cpp
    M Source/WebCore/rendering/svg/RenderSVGShape.cpp
    M Source/WebCore/rendering/svg/RenderSVGTextPath.cpp
    M Source/WebCore/rendering/svg/SVGPathData.cpp
    M Source/WebCore/rendering/svg/SVGPathData.h
    M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGShape.cpp
    M Source/WebCore/svg/SVGAnimateMotionElement.cpp
    M Source/WebCore/svg/SVGGraphicsElement.cpp

  Log Message:
  -----------
  Cleanup pathFromGraphicsElement
https://bugs.webkit.org/show_bug.cgi?id=264967

Reviewed by Chris Dumez.

Use switch statement instead of a HashMap in pathFromGraphicsElement.
Also make pathFromGraphicsElement take a reference, not a pointer, to SVGElement.

* Source/WebCore/rendering/PathOperation.cpp:
(WebCore::ReferencePathOperation::ReferencePathOperation):
* Source/WebCore/rendering/svg/RenderSVGModelObject.cpp:
(WebCore::RenderSVGModelObject::computeClipPath const):
* Source/WebCore/rendering/svg/RenderSVGShape.cpp:
(WebCore::RenderSVGShape::createPath const):
* Source/WebCore/rendering/svg/RenderSVGTextPath.cpp:
(WebCore::RenderSVGTextPath::layoutPath const):
* Source/WebCore/rendering/svg/SVGPathData.cpp:
(WebCore::pathFromGraphicsElement):
* Source/WebCore/rendering/svg/SVGPathData.h:
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGShape.cpp:
(WebCore::LegacyRenderSVGShape::createPath const):
* Source/WebCore/svg/SVGAnimateMotionElement.cpp:
(WebCore::SVGAnimateMotionElement::updateAnimationPath):
* Source/WebCore/svg/SVGGraphicsElement.cpp:
(WebCore::SVGGraphicsElement::toClipPath):

Canonical link: https://commits.webkit.org/270850@main




More information about the webkit-changes mailing list