[webkit-changes] [WebKit/WebKit] 131ac6: [GLIB] ASSERTION FAILED: response.httpStatusCode()...

[Vitaly Dyachkov]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 131ac6d0af068666f9854d6f9f4f3a73a7dc4a1f
      https://github.com/WebKit/WebKit/commit/131ac6d0af068666f9854d6f9f4f3a73a7dc4a1f
  Author: Vitaly Dyachkov <vitaly at igalia.com>
  Date:   2023-11-16 (Thu, 16 Nov 2023)

  Changed paths:
    M Source/WebCore/loader/SubresourceLoader.cpp

  Log Message:
  -----------
  [GLIB] ASSERTION FAILED: response.httpStatusCode() < 300 || response.httpStatusCode() >= 400 || response.httpStatusCode() == 304 || !response.httpHeaderField(HTTPHeaderName::Location) running imported/w3c/web-platform-tests/cors/preflight-failure.htm
https://bugs.webkit.org/show_bug.cgi?id=180693

Reviewed by Carlos Garcia Campos.

Normally, we process redirect responses in
`ResourceLoader::willSendRequestInternal()`. Exceptions are the
redirections with no or empty "Location" header.

In that scenario, we handle the redirect response in
`SubresourceLoader::didReceiveResponse()` where we assert that this is
actually the case.

The assertion uses `String::operator!()` which returns true only if
the String is null but not empty.

* Source/WebCore/loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::didReceiveResponse):

Canonical link: https://commits.webkit.org/270836@main