[webkit-changes] [WebKit/WebKit] 869419: Add support for grouping source map loading errors.

Jon Davis noreply at github.com
Thu Nov 16 10:21:58 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 869419c2de211c08fe24d0077a09d5289c06dc4f
      https://github.com/WebKit/WebKit/commit/869419c2de211c08fe24d0077a09d5289c06dc4f
  Author: Jonathan Davis <jond at apple.com>
  Date:   2023-11-16 (Thu, 16 Nov 2023)

  Changed paths:
    M Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
    M Source/WebInspectorUI/UserInterface/Base/Setting.js
    M Source/WebInspectorUI/UserInterface/Controllers/ConsoleManager.js
    M Source/WebInspectorUI/UserInterface/Controllers/JavaScriptLogViewController.js
    M Source/WebInspectorUI/UserInterface/Controllers/NetworkManager.js
    M Source/WebInspectorUI/UserInterface/Main.html
    M Source/WebInspectorUI/UserInterface/Views/ConsoleGroup.js
    M Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.css
    A Source/WebInspectorUI/UserInterface/Views/ConsoleSourceMapMessageGroup.js
    M Source/WebInspectorUI/UserInterface/Views/LogContentView.css
    M Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js

  Log Message:
  -----------
  Add support for grouping source map loading errors.
https://bugs.webkit.org/show_bug.cgi?id=256683
rdar://problem/109239646

Reviewed by Devin Rousso.

This feature is behind an experimental Web Inspector setting
available in the Settings tab, under Experimental. When enabled and
more than one source map loading error occurs, network error messages
with a URL that matches a known source map URL are collected into an
expandable group with a counter showing the number of messages.

* Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:
* Source/WebInspectorUI/UserInterface/Base/Setting.js:
* Source/WebInspectorUI/UserInterface/Controllers/ConsoleManager.js:
(WI.ConsoleManager):
(WI.ConsoleManager.prototype.get failedSourceMapConsoleMessages):
(WI.ConsoleManager.prototype.messageWasAdded):
(WI.ConsoleManager.prototype._handleSourceMapErrorMessage):
* Source/WebInspectorUI/UserInterface/Controllers/JavaScriptLogViewController.js:
(WI.JavaScriptLogViewController):
(WI.JavaScriptLogViewController.prototype.startNewSession):
(WI.JavaScriptLogViewController.prototype._didRenderConsoleMessageView):
(WI.JavaScriptLogViewController.prototype._handleFailedSourceMapMessageGrouping):
* Source/WebInspectorUI/UserInterface/Controllers/NetworkManager.js:
(WI.NetworkManager.prototype.get failedSourceMapURLs):
(WI.NetworkManager.prototype.get downloadingSourceMaps):
(WI.NetworkManager.prototype.isDownloadingSourceMapURL):
(WI.NetworkManager.prototype._sourceMapLoadAndParseFailed):
* Source/WebInspectorUI/UserInterface/Main.html:
* Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.css:
(.console-sourcemap-errors-group .errors-count,):
(.console-message .console-sourcemap-failures-container,):
(.console-message.expandable.expanded .console-sourcemap-failures-container,):
(.console-message .repeat-count): Deleted.
(.console-message .console-message-extra-parameters-container,): Deleted.
(.console-message.expandable.expanded .console-message-extra-parameters-container,): Deleted.
* Source/WebInspectorUI/UserInterface/Views/ConsoleSourceMapMessageGroup.js: Added.
(WI.ConsoleSourceMapMessageGroup):
(WI.ConsoleSourceMapMessageGroup.prototype.render):
(WI.ConsoleSourceMapMessageGroup.prototype.addMessageView):
(WI.ConsoleSourceMapMessageGroup.prototype.toggle):
(WI.ConsoleSourceMapMessageGroup.prototype._renderMessageCount):
* Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js:

Canonical link: https://commits.webkit.org/270834@main




More information about the webkit-changes mailing list