[webkit-changes] [WebKit/WebKit] d5bb23: [Curl] Implements authentication challenge handlin...

Kenji Shukuwa noreply at github.com
Wed Nov 15 22:20:49 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d5bb238e93ae50ca81233a2915e1f141d84b5b2c
      https://github.com/WebKit/WebKit/commit/d5bb238e93ae50ca81233a2915e1f141d84b5b2c
  Author: Kenji Shukuwa <kenji.shukuwa at open-tec.co.jp>
  Date:   2023-11-15 (Wed, 15 Nov 2023)

  Changed paths:
    M LayoutTests/platform/wincairo/TestExpectations
    M Source/WebCore/platform/network/curl/CurlStream.cpp
    M Source/WebCore/platform/network/curl/CurlStream.h
    M Source/WebCore/platform/network/curl/CurlStreamScheduler.cpp
    M Source/WebCore/platform/network/curl/CurlStreamScheduler.h
    M Source/WebKit/NetworkProcess/curl/NetworkSessionCurl.cpp
    M Source/WebKit/NetworkProcess/curl/NetworkSessionCurl.h
    M Source/WebKit/NetworkProcess/curl/WebSocketTaskCurl.cpp
    M Source/WebKit/NetworkProcess/curl/WebSocketTaskCurl.h

  Log Message:
  -----------
  [Curl] Implements authentication challenge handling when server certificate evaluation fails in the WebSocket
https://bugs.webkit.org/show_bug.cgi?id=264433

Reviewed by Fujii Hironori.

The WebSocket implementation of the Curl port did not implement handling
of authentication challenges when evaluating server certificates fails.
This causes some wss WebSocket tests to fail after 270374 at main (bug#264366).
To solve this problem, we implement authentication challenge handling
to WebSocket.

* LayoutTests/platform/wincairo/TestExpectations:
* Source/WebCore/platform/network/curl/CurlStream.cpp:
(WebCore::CurlStream::CurlStream):
(WebCore::CurlStream::notifyFailure):
* Source/WebCore/platform/network/curl/CurlStream.h:
(WebCore::CurlStream::create):
* Source/WebCore/platform/network/curl/CurlStreamScheduler.cpp:
(WebCore::CurlStreamScheduler::createStream):
* Source/WebCore/platform/network/curl/CurlStreamScheduler.h:
* Source/WebKit/NetworkProcess/curl/NetworkSessionCurl.cpp:
(WebKit::NetworkSessionCurl::createWebSocketTask):
(WebKit::NetworkSessionCurl::didReceiveChallenge):
* Source/WebKit/NetworkProcess/curl/NetworkSessionCurl.h:
* Source/WebKit/NetworkProcess/curl/WebSocketTaskCurl.cpp:
(WebKit::WebSocketTask::WebSocketTask):
(WebKit::WebSocketTask::networkSession):
(WebKit::WebSocketTask::didFail):
(WebKit::WebSocketTask::tryServerTrustEvaluation):
* Source/WebKit/NetworkProcess/curl/WebSocketTaskCurl.h:
(WebKit::WebSocketTask::webProxyPageID const):
(WebKit::WebSocketTask::topOrigin const):

Canonical link: https://commits.webkit.org/270809@main




More information about the webkit-changes mailing list