[webkit-changes] [WebKit/WebKit] 1007b7: [WebGPU] ArrayBuffer detaching on unmap is not imp...

mwyrzykowski noreply at github.com
Wed Nov 15 22:00:12 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1007b7a34ee9ad34c10f8032d13663567e7bdf4e
      https://github.com/WebKit/WebKit/commit/1007b7a34ee9ad34c10f8032d13663567e7bdf4e
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2023-11-15 (Wed, 15 Nov 2023)

  Changed paths:
    M Source/WebCore/Modules/WebGPU/GPUBuffer.cpp
    M Source/WebCore/Modules/WebGPU/GPUBuffer.h
    M Source/WebCore/Modules/WebGPU/GPUBuffer.idl
    M Source/WebCore/Modules/WebGPU/GPUDevice.cpp
    M Source/WebCore/Modules/WebGPU/GPUDevice.h
    M Source/WebCore/Modules/WebGPU/GPUDevice.idl

  Log Message:
  -----------
  [WebGPU] ArrayBuffer detaching on unmap is not implemented
https://bugs.webkit.org/show_bug.cgi?id=264865
radar://118439123

Reviewed by Dan Glastonbury.

Per section 5.2 of the WebGPU specification, ArrayBuffer instances
returned via GPUBuffer.getMappedRange should be detached after unmap
is called.

Enabling tests tracked by https://bugs.webkit.org/show_bug.cgi?id=264552
as mapping via postMessage and out of memory mapping tests still fail.

* Source/WebCore/Modules/WebGPU/GPUBuffer.cpp:
(WebCore::GPUBuffer::~GPUBuffer):
(WebCore::GPUBuffer::GPUBuffer):
(WebCore::makeArrayBuffer):
(WebCore::GPUBuffer::getMappedRange):
(WebCore::GPUBuffer::unmap):
(WebCore::GPUBuffer::internalUnmap):
(WebCore::GPUBuffer::destroy):
* Source/WebCore/Modules/WebGPU/GPUBuffer.h:
(WebCore::GPUBuffer::create):
* Source/WebCore/Modules/WebGPU/GPUBuffer.idl:
* Source/WebCore/Modules/WebGPU/GPUDevice.cpp:
(WebCore::GPUDevice::addBufferToUnmap):
(WebCore::GPUDevice::removeBufferToUnmap):
(WebCore::GPUDevice::destroy):
(WebCore::GPUDevice::createBuffer):
* Source/WebCore/Modules/WebGPU/GPUDevice.h:
* Source/WebCore/Modules/WebGPU/GPUDevice.idl:

Canonical link: https://commits.webkit.org/270806@main




More information about the webkit-changes mailing list