[webkit-changes] [WebKit/WebKit] f7c26d: [build.webkit.org] Replace Trac with commitStore

[Jonathan Bedard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f7c26dc807ef92a078756853af708f39a12c7f6a
      https://github.com/WebKit/WebKit/commit/f7c26dc807ef92a078756853af708f39a12c7f6a
  Author: Jonathan Bedard <jbedard at apple.com>
  Date:   2023-11-15 (Wed, 15 Nov 2023)

  Changed paths:
    M Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/BuildbotIteration.js
    M Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/BuildbotQueue.js
    M Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/BuildbotQueueView.js
    A Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/CommitStore.js
    R Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/Commits.js
    A Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/CommitsWebKitOrg.js
    M Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/Initialization.js
    M Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/Main.js
    M Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/QueueView.js
    A Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/ResultsDatabase.js
    R Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/Trac.js
    M Tools/CISupport/build-webkit-org/public_html/dashboard/index.html

  Log Message:
  -----------
  [build.webkit.org] Replace Trac with commitStore
rdar://118421383
https://bugs.webkit.org/show_bug.cgi?id=264842

Reviewed by Alexey Proskuryakov.

Remove code using trac.webkit.org and replace it with a CommitStore based on commits.webkit.org
which allows callers to both query for and store commit objects themselves.

* Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/BuildbotIteration.js:
(BuildbotIteration.prototype._deprecatedUpdateWithData): No need to propigate revision to Queue,
it already has the revision data.
* Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/BuildbotQueue.js:
(BuildbotQueue.prototype.compareIterationsByRevisions): Use commitStore instead of trac object.
(BuildbotQueue.prototype.updateIterationPosition): Deleted.
* Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/BuildbotQueueView.js:
(BuildbotQueueView.prototype._presentPopoverForRevisionRange): Use commitStore instead of trac object.
(BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
* Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/CommitStore.js: Added.
(CommitStore): Base class for all CommitSores.
(CommitStore.prototype.update): Update cached commit information for all branches.
(CommitStore.prototype.repr): Return the string representation of a commit.
(CommitStore.prototype.startPeriodicUpdates): Periodically run the 'update' function.
(CommitStore.prototype.uuidFor): Convert commit object to UUID integer for sorting.
(CommitStore.prototype.addCommit): Add commit object to store.
(CommitStore.prototype.branchPosition): Return an integer indicating what position a commit is on
a branch. Note that for git repositories, this will be a position relative to the set of cached commits.
(CommitStore.prototype.nextRevision): Return the next-oldest commit for a commit ref.
(CommitStore.prototype.indexOfRef): Return local index of a specified commit.
* Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/Commits.js: Removed.
* Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/CommitsWebKitOrg.js: Added.
(CommitsWebKitOrg.prototype.urlFor): Return commits.webkit.org URL for the specified ref.
(CommitsWebKitOrg.prototype.fetch): Start processing of fetch specified number commits from specified ref.
* Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/Initialization.js: Replace trac with commitStore.
* Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/Main.js: Replace trac with commitStore.
* Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/QueueView.js:
(QueueView.prototype._appendPendingRevisionCount): Replace trac with commitStore, handle overflow from
for relativel branch positions.
(QueueView.prototype._popoverLinesForCommitRange): Consult commitStore to determine how to stringify a commit.
(QueueView.prototype._presentPopoverForPendingCommits): Ditto.
* Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/ResultsDatabase.js:
(ResultsDatabase): Draft class to demonstrate how CommitStore protocol is extended.
(ResultsDatabase.prototype.urlFor): Return results database URL for the specified ref.
(ResultsDatabase.prototype.fetch): Start processing of fetch specified number commits from specified branch.
* Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/Trac.js: Removed.
* Tools/CISupport/build-webkit-org/public_html/dashboard/index.html: Remove Trac, include CommitStores.

Canonical link: https://commits.webkit.org/270793@main