[webkit-changes] [WebKit/WebKit] 6fae1c: GPUConnectionToWebProcess should return whether or...

Gavin noreply at github.com
Wed Nov 15 11:24:02 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6fae1cc5732df1a8c19c9f3cc39421baf45f82c9
      https://github.com/WebKit/WebKit/commit/6fae1cc5732df1a8c19c9f3cc39421baf45f82c9
  Author: Gavin Phillips <gavin.p at apple.com>
  Date:   2023-11-15 (Wed, 15 Nov 2023)

  Changed paths:
    M LayoutTests/ipc/send-invalid-sync-message-empty-reply-check-exception-expected.txt
    M LayoutTests/ipc/send-invalid-sync-message-empty-reply-check-exception.html
    M Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp

  Log Message:
  -----------
  GPUConnectionToWebProcess should return whether or not a particular receiver was able to handle a message not just that it was forwarded
https://bugs.webkit.org/show_bug.cgi?id=264815
rdar://118397083

Reviewed by Chris Dumez.

Currently GPUConnectionToWebProcess just returns true as soon as it
forwards a message to a receiver; completely ignoring whether it was
handled correctly or not. This is preventing us from detecting
deserialization failures for these messages. This change returns the
forwards the return result of the handler instead, aligning behavior
with NetworkConnectionToWebProcess and others.

* LayoutTests/ipc/send-invalid-sync-message-empty-reply-check-exception-expected.txt:
* LayoutTests/ipc/send-invalid-sync-message-empty-reply-check-exception.html:
* Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp:
(WebKit::GPUConnectionToWebProcess::dispatchSyncMessage):

Canonical link: https://commits.webkit.org/270778@main




More information about the webkit-changes mailing list