[webkit-changes] [WebKit/WebKit] 03a4b1: [webkitpy] make TestResultWriter.{actual, expected}...

Sam Sneddon noreply at github.com
Wed Nov 15 09:53:58 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 03a4b1575bc818054d0f81dece03a4ac12728fa7
      https://github.com/WebKit/WebKit/commit/03a4b1575bc818054d0f81dece03a4ac12728fa7
  Author: Sam Sneddon <gsnedders at apple.com>
  Date:   2023-11-15 (Wed, 15 Nov 2023)

  Changed paths:
    M Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py
    M Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py

  Log Message:
  -----------
  [webkitpy] make TestResultWriter.{actual,expected}_filename handle variants
https://bugs.webkit.org/show_bug.cgi?id=264816

Reviewed by Jonathan Bedard.

While 259006 at main made output_filename handle variants correctly, it
didn't make the other methods handle it correctly. This fixes this by
making all the methods behave correctly.

* Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
(TestResultWriter):
(TestResultWriter._modified_filename):
(TestResultWriter.expected_filename):
(TestResultWriter.actual_filename):
(TestResultWriter.output_filename):
* Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
(TestResultWriterTest.test_output_svg_filename):
(TestResultWriterTest):
(TestResultWriterTest.test_expected_filename):
(TestResultWriterTest.test_actual_filename):

Canonical link: https://commits.webkit.org/270773@main




More information about the webkit-changes mailing list