[webkit-changes] [WebKit/WebKit] 11908a: Stop using `-handleKeyInputMethodCommandForCurrent...

Wenson Hsieh noreply at github.com
Wed Nov 15 07:33:52 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 11908a5f5e62f24cf13ab414337b346d8f6996f5
      https://github.com/WebKit/WebKit/commit/11908a5f5e62f24cf13ab414337b346d8f6996f5
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2023-11-15 (Wed, 15 Nov 2023)

  Changed paths:
    M Source/WebKit/Platform/spi/ios/UIKitSPI.h
    M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm

  Log Message:
  -----------
  Stop using `-handleKeyInputMethodCommandForCurrentEvent` to defer key events to IME
https://bugs.webkit.org/show_bug.cgi?id=264749
rdar://118337970

Reviewed by Tim Horton and Abrar Rahman Protyasha.

Stop calling into `-[UIKeyboardImpl handleKeyInputMethodCommandForCurrentEvent]` directly, to defer
key events to IME; instead, use `-[UIAsyncTextInputDelegate deferEventHandlingToSystemWithContext:]`
with an event handling context that has both the `documentIsEditable` property as well as the new
`shouldEvaluateForInputSystemHandling` property set.

* Source/WebKit/Platform/spi/ios/UIKitSPI.h:
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _deferKeyEventToInputMethodEditing:]):

Pull out logic to defer key event handling to IME into a separate helper method, which uses the
`UIAsyncTextInputDelegate` when the feature flag is enabled, and otherwise falls back to calling
`-handleKeyInputMethodCommandForCurrentEvent`.

(-[WKContentView _internalHandleKeyWebEvent:withCompletionHandler:]):

Canonical link: https://commits.webkit.org/270768@main




More information about the webkit-changes mailing list