[webkit-changes] [WebKit/WebKit] 3855bd: ASSERTION FAILED: !((anchorType == PositionIsBefor...

[Vitaly Dyachkov]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3855bdaf1c1b4a90985a9c8c4e791fec6b499569
      https://github.com/WebKit/WebKit/commit/3855bdaf1c1b4a90985a9c8c4e791fec6b499569
  Author: Vitaly Dyachkov <vitaly at igalia.com>
  Date:   2023-11-15 (Wed, 15 Nov 2023)

  Changed paths:
    M LayoutTests/platform/glib/TestExpectations
    M Source/WebCore/dom/Node.h
    M Source/WebCore/dom/Position.h

  Log Message:
  -----------
  ASSERTION FAILED: !((anchorType == PositionIsBeforeChildren || anchorType == PositionIsAfterChildren) && (is<Text>(*m_anchorNode) || editingIgnoresContent(*m_anchorNode))) in WebCore::Position::Position
https://bugs.webkit.org/show_bug.cgi?id=164053

Reviewed by Ryosuke Niwa.

Since `firstPositionInNode()` and `lastPositionInNode()` take any node
as their argument, including `Comment`, we should use
`PositionIsOffsetInAnchor` for any `CharacterData`, not only for `Text`.

* LayoutTests/platform/glib/TestExpectations:
* Source/WebCore/dom/Node.h:
(WebCore::Node::isCharacterData const):
* Source/WebCore/dom/Position.h:
(WebCore::firstPositionInNode):
(WebCore::lastPositionInNode):

Canonical link: https://commits.webkit.org/270763@main