[webkit-changes] [WebKit/WebKit] 814d89: Implement FECompositeNeonArithmeticApplier

Said Abou-Hallawa noreply at github.com
Tue Nov 14 14:41:27 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 814d89056b21895a5c88315ec43a2fcd21e6a5c3
      https://github.com/WebKit/WebKit/commit/814d89056b21895a5c88315ec43a2fcd21e6a5c3
  Author: Said Abou-Hallawa <said at apple.com>
  Date:   2023-11-14 (Tue, 14 Nov 2023)

  Changed paths:
    M Source/WebCore/Sources.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    R Source/WebCore/platform/graphics/cpu/arm/filters/FECompositeArithmeticNEON.h
    A Source/WebCore/platform/graphics/cpu/arm/filters/FECompositeNeonArithmeticApplier.cpp
    A Source/WebCore/platform/graphics/cpu/arm/filters/FECompositeNeonArithmeticApplier.h
    M Source/WebCore/platform/graphics/filters/FEComposite.cpp
    M Source/WebCore/platform/graphics/filters/software/FECompositeSoftwareApplier.cpp
    M Source/WebCore/platform/graphics/filters/software/FECompositeSoftwareApplier.h
    A Source/WebCore/platform/graphics/filters/software/FECompositeSoftwareArithmeticApplier.cpp
    A Source/WebCore/platform/graphics/filters/software/FECompositeSoftwareArithmeticApplier.h

  Log Message:
  -----------
  Implement FECompositeNeonArithmeticApplier
https://bugs.webkit.org/show_bug.cgi?id=243432

Reviewed by Simon Fraser.

Move the software arithmetic FEComposite applier to a separate applier. Move the
FEComposite NEON code to a new applier named FECompositeNeonArithmeticApplier.
Make FEComposite::createSoftwareApplier() decide which applier to create.

* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/platform/graphics/cpu/arm/filters/FECompositeNeonArithmeticApplier.cpp: Renamed from Source/WebCore/platform/graphics/cpu/arm/filters/FECompositeArithmeticNEON.h.
(WebCore::FECompositeNeonArithmeticApplier::FECompositeNeonArithmeticApplier):
(WebCore::FECompositeNeonArithmeticApplier::computePixels):
(WebCore::FECompositeNeonArithmeticApplier::applyPlatform):
(WebCore::FECompositeNeonArithmeticApplier::apply const):
* Source/WebCore/platform/graphics/cpu/arm/filters/FECompositeNeonArithmeticApplier.h: Added.
* Source/WebCore/platform/graphics/filters/FEComposite.cpp:
(WebCore::FEComposite::createSoftwareApplier const):
* Source/WebCore/platform/graphics/filters/software/FECompositeSoftwareApplier.cpp:
(WebCore::FECompositeSoftwareApplier::FECompositeSoftwareApplier):
(WebCore::FECompositeSoftwareApplier::apply const):
(WebCore::FECompositeSoftwareApplier::clampByte): Deleted.
(WebCore::FECompositeSoftwareApplier::computeArithmeticPixels): Deleted.
(WebCore::FECompositeSoftwareApplier::computeArithmeticPixelsUnclamped): Deleted.
(WebCore::FECompositeSoftwareApplier::applyPlatformArithmetic): Deleted.
(WebCore::FECompositeSoftwareApplier::applyArithmetic const): Deleted.
(WebCore::FECompositeSoftwareApplier::applyNonArithmetic const): Deleted.
* Source/WebCore/platform/graphics/filters/software/FECompositeSoftwareApplier.h:
* Source/WebCore/platform/graphics/filters/software/FECompositeSoftwareArithmeticApplier.cpp: Added.
(WebCore::FECompositeSoftwareArithmeticApplier::FECompositeSoftwareArithmeticApplier):
(WebCore::FECompositeSoftwareArithmeticApplier::clampByte):
(WebCore::FECompositeSoftwareArithmeticApplier::computePixels):
(WebCore::FECompositeSoftwareArithmeticApplier::computePixelsUnclamped):
(WebCore::FECompositeSoftwareArithmeticApplier::applyPlatform):
(WebCore::FECompositeSoftwareArithmeticApplier::apply const):
* Source/WebCore/platform/graphics/filters/software/FECompositeSoftwareArithmeticApplier.h: Copied from Source/WebCore/platform/graphics/filters/software/FECompositeSoftwareApplier.h.

Canonical link: https://commits.webkit.org/270726@main




More information about the webkit-changes mailing list