[webkit-changes] [WebKit/WebKit] 5c5067: Move `hasExplicitlySetColorScheme` from `RenderSty...

[Aditya Keerthi]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5c50677827c04de8cafca536febb6d01d9a7549c
      https://github.com/WebKit/WebKit/commit/5c50677827c04de8cafca536febb6d01d9a7549c
  Author: Aditya Keerthi <akeerthi at apple.com>
  Date:   2023-11-14 (Tue, 14 Nov 2023)

  Changed paths:
    M Source/WebCore/rendering/style/RenderStyle.cpp
    M Source/WebCore/rendering/style/RenderStyle.h
    M Source/WebCore/rendering/style/RenderStyleInlines.h
    M Source/WebCore/rendering/style/RenderStyleSetters.h
    M Source/WebCore/rendering/style/StyleMiscNonInheritedData.cpp
    M Source/WebCore/rendering/style/StyleMiscNonInheritedData.h
    M Source/WebCore/style/StyleBuilderCustom.h

  Log Message:
  -----------
  Move `hasExplicitlySetColorScheme` from `RenderStyle::NonInheritedFlags` into `StyleMiscNonInheritedData`
https://bugs.webkit.org/show_bug.cgi?id=264794
rdar://118374921

Reviewed by Simon Fraser.

Move the `hasExplicitlySetColorScheme` into `StyleMiscNonInheritedData` to free
up an additional bit for new pseudo-elements in `RenderStyle::NonInheritedFlags`.

There are currently 6 bits of unused space (5 following this patch) in
`StyleMiscNonInheritedData`. Additionally, `hasExplicitlySetColorScheme` is not
expected to be too common, as in most use cases it will simply be specified on
the `:root`, and inherited on children.

* Source/WebCore/rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::NonInheritedFlags::copyNonInheritedFrom):
(WebCore::RenderStyle::conservativelyCollectChangedAnimatableProperties const):
* Source/WebCore/rendering/style/RenderStyle.h:
(WebCore::RenderStyle::setHasExplicitlySetColorScheme): Deleted.
(WebCore::RenderStyle::hasExplicitlySetColorScheme const): Deleted.
* Source/WebCore/rendering/style/RenderStyleInlines.h:
(WebCore::RenderStyle::hasExplicitlySetColorScheme const):
* Source/WebCore/rendering/style/RenderStyleSetters.h:
(WebCore::RenderStyle::setHasExplicitlySetColorScheme):
* Source/WebCore/rendering/style/StyleMiscNonInheritedData.cpp:
(WebCore::StyleMiscNonInheritedData::StyleMiscNonInheritedData):
(WebCore::StyleMiscNonInheritedData::operator== const):
* Source/WebCore/rendering/style/StyleMiscNonInheritedData.h:
* Source/WebCore/style/StyleBuilderCustom.h:
(WebCore::Style::BuilderCustom::applyValueColorScheme):

Canonical link: https://commits.webkit.org/270715@main