[webkit-changes] [WebKit/WebKit] e36c14: Add the ability for the IPCTestingAPI to report wh...

[Gavin]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e36c14395c0e952c75c21a9347377024e071a1b8
      https://github.com/WebKit/WebKit/commit/e36c14395c0e952c75c21a9347377024e071a1b8
  Author: Gavin Phillips <gavin.p at apple.com>
  Date:   2023-11-14 (Tue, 14 Nov 2023)

  Changed paths:
    A LayoutTests/ipc/send-invalid-sync-message-empty-reply-check-exception-expected.txt
    A LayoutTests/ipc/send-invalid-sync-message-empty-reply-check-exception.html
    M Source/WebKit/Platform/IPC/Connection.cpp
    M Source/WebKit/Platform/IPC/Decoder.cpp
    M Source/WebKit/Platform/IPC/Decoder.h
    M Source/WebKit/Platform/IPC/Encoder.cpp
    M Source/WebKit/Platform/IPC/Encoder.h
    M Source/WebKit/Platform/IPC/MessageFlags.h
    M Source/WebKit/Shared/IPCTester.cpp
    M Source/WebKit/Shared/IPCTester.h
    M Source/WebKit/Shared/IPCTester.messages.in
    M Source/WebKit/WebProcess/WebPage/IPCTestingAPI.cpp

  Log Message:
  -----------
  Add the ability for the IPCTestingAPI to report when a sync message fails to be received correctly
https://bugs.webkit.org/show_bug.cgi?id=264506
rdar://118188347

Reviewed by Alex Christensen.

Add the ability for the IPCTestingAPI to report when a sync message
fails to be received correctly. The existing behaviour is that both
failed messages and empty replies return an empty IPC object. This change
records the decoder validity on failure into the MessageSyncReply so the
IPCTestingAPI can raise an exception instead.

* Source/WebKit/Platform/IPC/Connection.cpp:
(IPC::Connection::dispatchSyncMessage):
* Source/WebKit/Platform/IPC/Decoder.cpp:
(IPC::Decoder::hasMessageTestingError const):
* Source/WebKit/Platform/IPC/Decoder.h:
* Source/WebKit/Platform/IPC/Encoder.cpp:
(IPC::Encoder::setMessageTestingError):
* Source/WebKit/Platform/IPC/Encoder.h:
* Source/WebKit/Platform/IPC/MessageFlags.h:
* Source/WebKit/WebProcess/WebPage/IPCTestingAPI.cpp:
(WebKit::IPCTestingAPI::jsResultFromReplyDecoder):

Canonical link: https://commits.webkit.org/270705@main