[webkit-changes] [WebKit/WebKit] 36b04e: [WebGPU] https://webgpu.github.io/webgpu-samples/s...

mwyrzykowski noreply at github.com
Mon Nov 13 22:48:34 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 36b04e3cb9bc703b4714b7379e48b2492b29d0db
      https://github.com/WebKit/WebKit/commit/36b04e3cb9bc703b4714b7379e48b2492b29d0db
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2023-11-13 (Mon, 13 Nov 2023)

  Changed paths:
    M Source/WebCore/CMakeLists.txt
    M Source/WebCore/DerivedSources.make
    M Source/WebCore/Headers.cmake
    R Source/WebCore/Modules/WebGPU/GPUComputePassTimestampLocation.h
    R Source/WebCore/Modules/WebGPU/GPUComputePassTimestampLocation.idl
    M Source/WebCore/Modules/WebGPU/GPUComputePassTimestampWrites.h
    R Source/WebCore/Modules/WebGPU/GPURenderPassTimestampLocation.h
    R Source/WebCore/Modules/WebGPU/GPURenderPassTimestampLocation.idl
    M Source/WebCore/Modules/WebGPU/GPURenderPassTimestampWrites.h
    M Source/WebCore/Modules/WebGPU/Implementation/WebGPUAdapterImpl.cpp
    M Source/WebCore/Modules/WebGPU/Implementation/WebGPUCommandEncoderImpl.cpp
    M Source/WebCore/Modules/WebGPU/Implementation/WebGPUConvertToBackingContext.cpp
    M Source/WebCore/Modules/WebGPU/Implementation/WebGPUConvertToBackingContext.h
    M Source/WebCore/Modules/WebGPU/Implementation/WebGPUDeviceImpl.cpp
    M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPU.serialization.in
    R Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUComputePassTimestampLocation.h
    M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUComputePassTimestampWrites.h
    R Source/WebCore/Modules/WebGPU/InternalAPI/WebGPURenderPassTimestampLocation.h
    M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPURenderPassTimestampWrites.h
    M Source/WebCore/Sources.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebGPU/WebGPU/CommandEncoder.mm
    M Source/WebGPU/WebGPU/ComputePassEncoder.h
    M Source/WebGPU/WebGPU/ComputePassEncoder.mm
    M Source/WebGPU/WebGPU/HardwareCapabilities.mm
    M Source/WebGPU/WebGPU/QuerySet.h
    M Source/WebGPU/WebGPU/QuerySet.mm
    M Source/WebGPU/WebGPU/RenderPassEncoder.h
    M Source/WebGPU/WebGPU/RenderPassEncoder.mm
    M Source/WebGPU/WebGPU/WebGPU.h
    M Source/WebKit/Scripts/webkit/messages.py
    M Source/WebKit/Shared/WebGPU/WebGPUComputePassTimestampWrites.h
    M Source/WebKit/Shared/WebGPU/WebGPURenderPassTimestampWrites.h

  Log Message:
  -----------
  [WebGPU] https://webgpu.github.io/webgpu-samples/samples/computeBoids does not work
https://bugs.webkit.org/show_bug.cgi?id=264719
<radar://118315907>

Reviewed by Dan Glastonbury.

Timestamps query was added to computeBoids but we implemented the older version
in the specification.

The newer version is simpler, so support that one.

Pipeline statistics query feature was removed from WebGPU so remove it.

* Source/WebCore/CMakeLists.txt:
* Source/WebCore/DerivedSources.make:
* Source/WebCore/Headers.cmake:
* Source/WebCore/Modules/WebGPU/GPUComputePassTimestampLocation.h: Removed.
* Source/WebCore/Modules/WebGPU/GPUComputePassTimestampLocation.idl: Removed.
* Source/WebCore/Modules/WebGPU/GPUComputePassTimestampWrites.h:
* Source/WebCore/Modules/WebGPU/GPURenderPassTimestampLocation.h: Removed.
* Source/WebCore/Modules/WebGPU/GPURenderPassTimestampLocation.idl: Removed.
* Source/WebCore/Modules/WebGPU/GPURenderPassTimestampWrites.h:
* Source/WebCore/Modules/WebGPU/Implementation/WebGPUAdapterImpl.cpp:
(WebCore::WebGPU::supportedFeatures):
* Source/WebCore/Modules/WebGPU/Implementation/WebGPUCommandEncoderImpl.cpp:
(WebCore::WebGPU::CommandEncoderImpl::beginRenderPass):
(WebCore::WebGPU::CommandEncoderImpl::beginComputePass):
* Source/WebCore/Modules/WebGPU/Implementation/WebGPUConvertToBackingContext.cpp:
* Source/WebCore/Modules/WebGPU/Implementation/WebGPUConvertToBackingContext.h:
* Source/WebCore/Modules/WebGPU/Implementation/WebGPUDeviceImpl.cpp:
(WebCore::WebGPU::DeviceImpl::createQuerySet):
* Source/WebCore/Modules/WebGPU/InternalAPI/WebGPU.serialization.in:
* Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUComputePassTimestampLocation.h: Removed.
* Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUComputePassTimestampWrites.h:
* Source/WebCore/Modules/WebGPU/InternalAPI/WebGPURenderPassTimestampLocation.h: Removed.
* Source/WebCore/Modules/WebGPU/InternalAPI/WebGPURenderPassTimestampWrites.h:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebGPU/WebGPU/CommandEncoder.mm:
(WebGPU::CommandEncoder::validateComputePassDescriptor const):
(WebGPU::CommandEncoder::beginComputePass):
(WebGPU::CommandEncoder::validateRenderPassDescriptor const):
(WebGPU::CommandEncoder::beginRenderPass):
(WebGPU::CommandEncoder::resolveQuerySet):
* Source/WebGPU/WebGPU/ComputePassEncoder.h:
* Source/WebGPU/WebGPU/ComputePassEncoder.mm:
(WebGPU::ComputePassEncoder::ComputePassEncoder):
(WebGPU::ComputePassEncoder::beginPipelineStatisticsQuery): Deleted.
(WebGPU::ComputePassEncoder::endPipelineStatisticsQuery): Deleted.
(wgpuComputePassEncoderBeginPipelineStatisticsQuery): Deleted.
(wgpuComputePassEncoderEndPipelineStatisticsQuery): Deleted.
* Source/WebGPU/WebGPU/HardwareCapabilities.mm:
(WebGPU::baseFeatures):
* Source/WebGPU/WebGPU/QuerySet.h:
* Source/WebGPU/WebGPU/QuerySet.mm:
(WebGPU::Device::createQuerySet):
(WebGPU::QuerySet::setOverrideLocation):
(WebGPU::QuerySet::encodeResolveCommands const):
* Source/WebGPU/WebGPU/RenderPassEncoder.h:
* Source/WebGPU/WebGPU/RenderPassEncoder.mm:
(WebGPU::RenderPassEncoder::RenderPassEncoder):
(WebGPU::RenderPassEncoder::beginPipelineStatisticsQuery): Deleted.
(WebGPU::RenderPassEncoder::endPipelineStatisticsQuery): Deleted.
(wgpuRenderPassEncoderBeginPipelineStatisticsQuery): Deleted.
(wgpuRenderPassEncoderEndPipelineStatisticsQuery): Deleted.
* Source/WebGPU/WebGPU/WebGPU.h:
* Source/WebKit/Scripts/webkit/messages.py:
(headers_for_type):
* Source/WebKit/Shared/WebGPU/WebGPUComputePassTimestampWrites.h:
* Source/WebKit/Shared/WebGPU/WebGPURenderPassTimestampWrites.h:

Canonical link: https://commits.webkit.org/270694@main




More information about the webkit-changes mailing list