[webkit-changes] [WebKit/WebKit] 58e56e: [Cocoa] Refactor: remote MediaPlayerPrivateAVFound...

Jer Noble noreply at github.com
Mon Nov 13 12:17:41 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 58e56ea67c7b543bbec9cf17ffcabab78b7d6c2e
      https://github.com/WebKit/WebKit/commit/58e56ea67c7b543bbec9cf17ffcabab78b7d6c2e
  Author: Jer Noble <jer.noble at apple.com>
  Date:   2023-11-13 (Mon, 13 Nov 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp
    M Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h
    M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm

  Log Message:
  -----------
  [Cocoa] Refactor: remote MediaPlayerPrivateAVFoundation::scheduleMainThreadNotification()
https://bugs.webkit.org/show_bug.cgi?id=264746
rdar://118335975

Reviewed by Andy Estes.

MediaPlayerPrivateAVFoundation::scheduleMainThreadNotification() supported an elaborate list of
notification types, only two of which were used after the removal of MediaPlayerPrivateAVFoundationCF.
Replace these two notifications with standard callbacks.

* Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):
(WebCore::MediaPlayerPrivateAVFoundation::setPreload):
(WebCore::MediaPlayerPrivateAVFoundation::trackModeChanged):
(WebCore::MediaPlayerPrivateAVFoundation::setDelayCallbacks const): Deleted.
(WebCore::MediaPlayerPrivateAVFoundation::mainThreadCallback): Deleted.
(WebCore::MediaPlayerPrivateAVFoundation::clearMainThreadPendingFlag): Deleted.
(WebCore::MediaPlayerPrivateAVFoundation::scheduleMainThreadNotification): Deleted.
(WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification): Deleted.
* Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
* Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem):
(WebCore::MediaPlayerPrivateAVFoundationObjC::checkPlayability):
(WebCore::MediaPlayerPrivateAVFoundationObjC::seekToTargetInternal):
(WebCore::MediaPlayerPrivateAVFoundationObjC::setPlayerRate):
(WebCore::MediaPlayerPrivateAVFoundationObjC::paintCurrentFrameInContext):
(WebCore::MediaPlayerPrivateAVFoundationObjC::setWirelessVideoPlaybackDisabled):
(WebCore::MediaPlayerPrivateAVFoundationObjC::setShouldPlayToPlaybackTarget):

Canonical link: https://commits.webkit.org/270659@main




More information about the webkit-changes mailing list