[webkit-changes] [WebKit/WebKit] 01dea9: Avoid divide-by-zero in webrtc::StreamStatistician...

Commit Queue noreply at github.com
Mon Nov 13 12:03:24 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 01dea93c203eba29a991917b2c9c77c427c0b166
      https://github.com/WebKit/WebKit/commit/01dea93c203eba29a991917b2c9c77c427c0b166
  Author: David Kilzer <ddkilzer at apple.com>
  Date:   2023-11-13 (Mon, 13 Nov 2023)

  Changed paths:
    M Source/ThirdParty/libwebrtc/Source/webrtc/modules/rtp_rtcp/source/receive_statistics_impl.cc
    M Source/ThirdParty/libwebrtc/Source/webrtc/test/fuzzers/utils/rtp_replayer.cc

  Log Message:
  -----------
  Avoid divide-by-zero in webrtc::StreamStatisticianImpl::BitrateReceived
https://bugs.webkit.org/show_bug.cgi?id=264718
<rdar://117912996>

Reviewed by Youenn Fablet.

Merge upstream 7dbf55437f109cb13d131d91ba645029686fa247 by
Harald Alvestrand <hta at webrtc.org>.

* Source/ThirdParty/libwebrtc/Source/webrtc/modules/rtp_rtcp/source/receive_statistics_impl.cc:
* Source/ThirdParty/libwebrtc/Source/webrtc/test/fuzzers/utils/rtp_replayer.cc:

--

Ensure payload type frequency does not cause divide-by-zero

This CL does 2 things:
- Change the DCHECK for payload_type_frequency to a CHECK (so that
this error will be a crash not a divide-by-zero)
- Change the replay helper that was used by the fuzzer to set the
frequency of the packets to the video value (90K).

Bug: chromium:1466826
Change-Id: I39941f250b1782b36a3bcddfd347a016591466ec
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/312700
Commit-Queue: Harald Alvestrand <hta at webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap at webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40468}
Canonical link: https://commits.webkit.org/270656@main




More information about the webkit-changes mailing list