[webkit-changes] [WebKit/WebKit] 7c1250: REGRESSION(270320 at main): Speedometer3/Editor-TipTa...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7c1250d993d60925c2fd8185e0976e32b7bcd592
      https://github.com/WebKit/WebKit/commit/7c1250d993d60925c2fd8185e0976e32b7bcd592
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-11-13 (Mon, 13 Nov 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/Font.h
    M Source/WebCore/platform/graphics/FontCascade.cpp
    M Source/WebCore/platform/graphics/FontCascadeFonts.cpp
    M Source/WebCore/platform/graphics/GlyphPage.h
    M Source/WebCore/platform/graphics/cairo/FontCairoHarfbuzzNG.cpp

  Log Message:
  -----------
  REGRESSION(270320 at main): Speedometer3/Editor-TipTap 4-6%
https://bugs.webkit.org/show_bug.cgi?id=264744
rdar://118312367

Unreviewed, partial revert of 270320 at main to address the Speedometer
regression. In 270320 at main, I had converted all remaining
CheckedPtr<Font> to WeakPtr<Font> to address crashes. However, we
didn't need to convert GlyphData's font data member. Reverting this
part of the change doesn't regress the layout test introduced in
270320 at main but I have confirmed that it resolves the Speedometer
regression.

* Source/WebCore/platform/graphics/Font.h:
* Source/WebCore/platform/graphics/FontCascade.cpp:
(WebCore::FontCascade::emphasisMarkAscent const):
(WebCore::FontCascade::emphasisMarkDescent const):
(WebCore::FontCascade::drawEmphasisMarks const):
* Source/WebCore/platform/graphics/FontCascadeFonts.cpp:
(WebCore::MixedFontGlyphPage::setGlyphDataForIndex):
* Source/WebCore/platform/graphics/GlyphPage.h:

Canonical link: https://commits.webkit.org/270646@main