[webkit-changes] [WebKit/WebKit] d0b51b: [GStreamer][EME][Debug] Flaky assertions on weak p...

Philippe Normand noreply at github.com
Mon Nov 13 01:33:03 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d0b51b0807c8ea8221a1121dbc895eee7b8a1249
      https://github.com/WebKit/WebKit/commit/d0b51b0807c8ea8221a1121dbc895eee7b8a1249
  Author: Philippe Normand <philn at igalia.com>
  Date:   2023-11-13 (Mon, 13 Nov 2023)

  Changed paths:
    M Source/WebCore/platform/encryptedmedia/CDMProxy.cpp

  Log Message:
  -----------
  [GStreamer][EME][Debug] Flaky assertions on weak pointer
https://bugs.webkit.org/show_bug.cgi?id=264705

Reviewed by Xabier Rodriguez-Calvar.

Replace ASSERTs on WeakPtr by runtime checks, the pointer can be null, it's a valid scenario, so it
shouldn't be in an ASSERT.

* Source/WebCore/platform/encryptedmedia/CDMProxy.cpp:
(WebCore::CDMInstanceProxy::startedWaitingForKey):
(WebCore::CDMInstanceProxy::stoppedWaitingForKey):

Canonical link: https://commits.webkit.org/270627@main




More information about the webkit-changes mailing list