[webkit-changes] [WebKit/WebKit] 76bc3f: [GStreamer] Ignore early EOS only when not looping

Commit Queue noreply at github.com
Sat Nov 11 07:22:22 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 76bc3f4aa79352cdd1693bc793f689ba87d8094c
      https://github.com/WebKit/WebKit/commit/76bc3f4aa79352cdd1693bc793f689ba87d8094c
  Author: Marek Vasut <marex at denx.de>
  Date:   2023-11-11 (Sat, 11 Nov 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp

  Log Message:
  -----------
  [GStreamer] Ignore early EOS only when not looping
https://bugs.webkit.org/show_bug.cgi?id=264398

Reviewed by Philippe Normand.

When playing video in a loop using HTML5 video element, the Gstreamer
debug log sometimes contains the following message, which prevents the
WPE from correctly stopping the playback before restarting it for the
next loop and the playback ends up paused forever:

```
webkitmediaplayer MediaPlayerPrivateGStreamer.cpp:1851:handleMessage:<video-1> EOS received but position {23823333333/1000000000 = 23.823333333} is still in the finite playable limits [{0/1 = 0}, {23828333333/1000000000 = 23.828333333}], ignoring it
```

Ignore early EOS only when not looping, otherwise unconditionally
indicate the stream has ended.

* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::handleMessage):

Canonical link: https://commits.webkit.org/270593@main




More information about the webkit-changes mailing list