[webkit-changes] [WebKit/WebKit] 77b692: [UnifiedPDF] Re-enable the PDF HUD

[Tim Horton]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 77b692aefd85b2b8896817c2198f1f6cec4e0042
      https://github.com/WebKit/WebKit/commit/77b692aefd85b2b8896817c2198f1f6cec4e0042
  Author: Tim Horton <timothy_horton at apple.com>
  Date:   2023-11-10 (Fri, 10 Nov 2023)

  Changed paths:
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm
    M Source/WebKit/WebProcess/WebPage/WebPage.h
    M Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm

  Log Message:
  -----------
  [UnifiedPDF] Re-enable the PDF HUD
https://bugs.webkit.org/show_bug.cgi?id=264608
<rdar://problem/118154838>

Reviewed by Richard Robinson and Simon Fraser.

Hoist PDFPlugin's HUD creation/destruction code into PDFPluginBase, and add
empty implementations of the actions.

* Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::PDFPlugin):
(WebKit::PDFPlugin::teardown):
(WebKit::PDFPlugin::~PDFPlugin): Deleted.
(WebKit::PDFPlugin::hudEnabled const): Deleted.
(WebKit::PDFPlugin::frameForHUD const): Deleted.
(WebKit::PDFPlugin::updatePDFHUDLocation): Deleted.
(WebKit::PDFPlugin::convertFromPluginToPDFView const): Deleted.
(WebKit::PDFPlugin::convertFromPDFViewToRootView const): Deleted.
(WebKit::PDFPlugin::convertFromRootViewToPDFView const): Deleted.
(WebKit::PDFPlugin::convertFromPDFViewToScreen const): Deleted.
(WebKit::PDFPlugin::boundsOnScreen const): Deleted.
(WebKit::PDFPlugin::visibilityDidChange): Deleted.
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h:
(WebKit::PDFPluginBase::identifier const):
(WebKit::PDFPluginBase::visibilityDidChange): Deleted.
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm:
(WebKit::PDFPluginBase::PDFPluginBase):
(WebKit::PDFPluginBase::~PDFPluginBase):
(WebKit::PDFPluginBase::teardown):
(WebKit::PDFPluginBase::geometryDidChange):
(WebKit::PDFPluginBase::visibilityDidChange):
(WebKit::PDFPluginBase::convertFromPluginToPDFView const):
(WebKit::PDFPluginBase::convertFromPDFViewToRootView const):
(WebKit::PDFPluginBase::convertFromRootViewToPDFView const):
(WebKit::PDFPluginBase::convertFromPDFViewToScreen const):
(WebKit::PDFPluginBase::boundsOnScreen const):
(WebKit::PDFPluginBase::updatePDFHUDLocation):
(WebKit::PDFPluginBase::frameForHUD const):
(WebKit::PDFPluginBase::hudEnabled const):
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::teardown):
(WebKit::UnifiedPDFPlugin::countFindMatches):
(WebKit::UnifiedPDFPlugin::findString):
(WebKit::UnifiedPDFPlugin::zoomIn):
(WebKit::UnifiedPDFPlugin::zoomOut):
(WebKit::UnifiedPDFPlugin::save):
(WebKit::UnifiedPDFPlugin::openWithPreview):
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::createPDFHUD):
(WebKit::WebPage::updatePDFHUDLocation):
(WebKit::WebPage::removePDFHUD):

Canonical link: https://commits.webkit.org/270560@main