[webkit-changes] [WebKit/WebKit] acfe28: Support `<select>` in vertical writing mode
Aditya Keerthi
noreply at github.com
Fri Nov 10 10:08:57 PST 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: acfe2805bf055c67d7594a694f535f074551bf90
https://github.com/WebKit/WebKit/commit/acfe2805bf055c67d7594a694f535f074551bf90
Author: Aditya Keerthi <akeerthi at apple.com>
Date: 2023-11-10 (Fri, 10 Nov 2023)
Changed paths:
M LayoutTests/TestExpectations
M LayoutTests/fast/forms/vertical-writing-mode/listbox-drag-horizontal-scrollbar-expected.txt
M LayoutTests/fast/forms/vertical-writing-mode/listbox-drag-horizontal-scrollbar.html
M LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/select-appearance-native-computed-style-expected.txt
M LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/select-multiple-keyboard-selection.optional-expected.txt
M LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/select-multiple-options-visual-order-expected.txt
M LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/select-multiple-scrolling.optional-expected.txt
M LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/select-size-scrolling-and-sizing.optional-expected.txt
M LayoutTests/platform/glib/TestExpectations
R LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-writing-modes/forms/select-appearance-native-computed-style-expected.txt
A LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-writing-modes/forms/select-multiple-scrolling.optional-expected.txt
R LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-writing-modes/forms/select-appearance-native-computed-style-expected.txt
M Source/WebCore/css/horizontalFormControls.css
M Source/WebCore/css/html.css
Log Message:
-----------
Support `<select>` in vertical writing mode
https://bugs.webkit.org/show_bug.cgi?id=117233
rdar://102651643
Reviewed by Tim Nguyen.
`<select>`, `<select multiple>`, and `<select size=N>` work in vertical writing
modes following fixes in `RenderMenuList`, `RenderListBox`, and related code.
Allow the use of vertical writing modes with `<select>` when the
`VerticalFormControlsEnabled` setting is turned on.
* LayoutTests/TestExpectations:
* LayoutTests/fast/forms/vertical-writing-mode/listbox-drag-horizontal-scrollbar-expected.txt:
* LayoutTests/fast/forms/vertical-writing-mode/listbox-drag-horizontal-scrollbar.html:
Adjust this test to avoid assuming a platform-specific option height. Simply
check that `scrollLeft` is greater than zero to verify that scrolling has occurred.
* LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/select-appearance-native-computed-style-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/select-multiple-keyboard-selection.optional-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/select-multiple-options-visual-order-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/select-multiple-scrolling.optional-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/select-size-scrolling-and-sizing.optional-expected.txt:
* LayoutTests/platform/glib/TestExpectations:
* LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-writing-modes/forms/select-appearance-native-computed-style-expected.txt: Removed.
* LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-writing-modes/forms/select-multiple-scrolling.optional-expected.txt: Added.
* LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-writing-modes/forms/select-appearance-native-computed-style-expected.txt: Removed.
* Source/WebCore/css/horizontalFormControls.css:
(button, textarea, progress, meter, input, select):
* Source/WebCore/css/html.css:
(select): Deleted.
Canonical link: https://commits.webkit.org/270545@main
More information about the webkit-changes
mailing list