[webkit-changes] [WebKit/WebKit] 2d41e7: LocalFrameView: Use a weak reference for embedded ...

[Claudio Saavedra]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2d41e7df7e956440d7df6ed59e3a3e898b50f1c1
      https://github.com/WebKit/WebKit/commit/2d41e7df7e956440d7df6ed59e3a3e898b50f1c1
  Author: Claudio Saavedra <csaavedra at igalia.com>
  Date:   2023-11-10 (Fri, 10 Nov 2023)

  Changed paths:
    A LayoutTests/fast/dom/move-embedded-during-update-expected.txt
    A LayoutTests/fast/dom/move-embedded-during-update.html
    M Source/WebCore/page/LocalFrameView.cpp
    M Source/WebCore/page/LocalFrameView.h

  Log Message:
  -----------
  LocalFrameView: Use a weak reference for embedded objects during update
https://bugs.webkit.org/show_bug.cgi?id=263179
rdar://116715302

Reviewed by Chris Dumez.

Embedded objects can be remove during update, so it's safer to
use a weak reference to avoid leaking one.

* LayoutTests/fast/dom/move-embedded-during-update-expected.txt: Added.
* LayoutTests/fast/dom/move-embedded-during-update.html: Added.
* Source/WebCore/page/LocalFrameView.cpp:
(WebCore::LocalFrameView::updateEmbeddedObject):
(WebCore::LocalFrameView::updateEmbeddedObjects):
* Source/WebCore/page/LocalFrameView.h:

Co-authored-by: Žan Doberšek <zdobersek at igalia.com>
Canonical link: https://commits.webkit.org/270541@main