[webkit-changes] [WebKit/WebKit] b6413f: Correct <input type=checkbox switch> macOS RTL thu...

Anne van Kesteren noreply at github.com
Fri Nov 10 08:32:24 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b6413fe07ea1aa277f2e149c60a7b1584577a774
      https://github.com/WebKit/WebKit/commit/b6413fe07ea1aa277f2e149c60a7b1584577a774
  Author: Anne van Kesteren <annevk at annevk.nl>
  Date:   2023-11-10 (Fri, 10 Nov 2023)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/input-checkbox-switch-rtl-notref.html
    A LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/input-checkbox-switch-rtl.tentative-expected-mismatch.html
    A LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/input-checkbox-switch-rtl.tentative.html
    M LayoutTests/platform/glib/TestExpectations
    M LayoutTests/platform/ios/TestExpectations
    M Source/WebCore/platform/graphics/mac/controls/SwitchThumbMac.mm

  Log Message:
  -----------
  Correct <input type=checkbox switch> macOS RTL thumb placement
https://bugs.webkit.org/show_bug.cgi?id=264477
rdar://118174107

Reviewed by Mike Wyrzykowski.

While most RTL aspects are handled by bitmaps from AppKit, thumb
placement is on us and I forgot about it initially.

Test is exported via
https://github.com/web-platform-tests/wpt/pull/43074.

* LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/input-checkbox-switch-rtl-notref.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/input-checkbox-switch-rtl.tentative-expected-mismatch.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/input-checkbox-switch-rtl.tentative.html: Added.
* LayoutTests/platform/glib/TestExpectations:
* LayoutTests/platform/ios/TestExpectations:
* Source/WebCore/platform/graphics/mac/controls/SwitchThumbMac.mm:
(WebCore::SwitchThumbMac::draw):

Canonical link: https://commits.webkit.org/270536@main




More information about the webkit-changes mailing list