[webkit-changes] [WebKit/WebKit] 73237f: Throw exception if querying SVGAnimationElement wi...

Ahmad Saleem noreply at github.com
Fri Nov 10 02:26:48 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 73237f2bdac8b49a7a7e9ddaa1f55cdc7a76180d
      https://github.com/WebKit/WebKit/commit/73237f2bdac8b49a7a7e9ddaa1f55cdc7a76180d
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2023-11-10 (Fri, 10 Nov 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/svg/animations/scripted/SVGAnimationElement-exceptions-expected.txt
    M Source/WebCore/svg/SVGAnimationElement.cpp
    M Source/WebCore/svg/SVGAnimationElement.h

  Log Message:
  -----------
  Throw exception if querying SVGAnimationElement with unresolved interval

https://bugs.webkit.org/show_bug.cgi?id=264543

Reviewed by Said Abou-Hallawa.

This patch is to align WebKit with Blink / Chromium, Gecko / Firefox and Web Specification [1].

[1] https://svgwg.org/specs/animations/#InterfaceSVGAnimationElement

For 'getStartTime', it throws 'DOMException' (NVALID_STATE_ERR) and for 'getSimpleDuration', it throws 'DOMException' (NOT_SUPPORTED_ERR).

* Source/WebCore/svg/SVGAnimationElement.cpp:
(SVGAnimationElement::getStartTime):
(SVGAnimationElement::getSimpleDuration):
* Source/WebCore/svg/SVGAnimationElement.h:
* LayoutTests/imported/w3c/web-platform-tests/svg/animations/scripted/SVGAnimationElement-exceptions-expected.txt: Rebaselined

Canonical link: https://commits.webkit.org/270519@main




More information about the webkit-changes mailing list