[webkit-changes] [WebKit/WebKit] 8fa45e: Assert that several private protocol methods are n...

Wenson Hsieh noreply at github.com
Thu Nov 9 18:59:32 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8fa45e3b720a5f0bbfca9db9248288713359744a
      https://github.com/WebKit/WebKit/commit/8fa45e3b720a5f0bbfca9db9248288713359744a
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2023-11-09 (Thu, 09 Nov 2023)

  Changed paths:
    M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm

  Log Message:
  -----------
  Assert that several private protocol methods are never called when async interactions are enabled
https://bugs.webkit.org/show_bug.cgi?id=264522
rdar://118202852

Reviewed by Tim Horton, Megan Gardner and Abrar Rahman Protyasha.

Add several release assertions to make it easier to identify cases where legacy UIKit SPIs are still
being exercised, in the case where these SPI methods are invoked, but the async interactions are
enabled in WebKit.

* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView startAutoscroll:]):
(-[WKContentView scrollSelectionToVisible:]):
(-[WKContentView requestAutocorrectionRectsForString:withCompletionHandler:]):
(-[WKContentView applyAutocorrection:toString:isCandidate:withCompletionHandler:]):
(-[WKContentView requestAutocorrectionContextWithCompletionHandler:]):
(-[WKContentView modifierFlagsDidChangeFrom:to:]):
(-[WKContentView handleKeyWebEvent:withCompletionHandler:]):
(-[WKContentView _internalHandleKeyWebEvent:withCompletionHandler:]):
(-[WKContentView requestRVItemInSelectedRangeWithCompletionHandler:]):
(-[WKContentView prepareSelectionForContextMenuWithLocationInView:completionHandler:]):
(-[WKContentView handleAsyncKeyEvent:withCompletionHandler:]):
(-[WKContentView handleKeyWebEvent:]): Deleted.

Canonical link: https://commits.webkit.org/270497@main




More information about the webkit-changes mailing list