[webkit-changes] [WebKit/WebKit] e1a980: [iOS] Stop using `-_presentMenuAtLocation:` when `...

Wenson Hsieh noreply at github.com
Thu Nov 9 12:59:36 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e1a9807dea0ef720187884855f72b10464b0d206
      https://github.com/WebKit/WebKit/commit/e1a9807dea0ef720187884855f72b10464b0d206
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2023-11-09 (Thu, 09 Nov 2023)

  Changed paths:
    M Source/WebKit/Platform/spi/ios/UIKitSPI.h
    M Source/WebKit/UIProcess/ios/CompactContextMenuPresenter.mm
    M Source/WebKit/UIProcess/ios/WKContentViewInteraction.h
    M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm

  Log Message:
  -----------
  [iOS] Stop using `-_presentMenuAtLocation:` when `-[UIButton performPrimaryAction]` is available
https://bugs.webkit.org/show_bug.cgi?id=264503
rdar://114331050

Reviewed by Aditya Keerthi.

Remove the last usage of `-[UIContextMenuInteraction _presentMenuAtLocation:]`, by setting
`showsMenuAsPrimaryAction` to YES on the `CompactContextMenuPresenter`'s hidden `UIButton`, and then
using the new `-performPrimaryAction` method for programmatic menu presentation.

* Source/WebKit/Platform/spi/ios/UIKitSPI.h:
* Source/WebKit/UIProcess/ios/CompactContextMenuPresenter.mm:
(WebKit::CompactContextMenuPresenter::CompactContextMenuPresenter):
(WebKit::CompactContextMenuPresenter::present):
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.h:
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView presentContextMenu:atLocation:]): Deleted.

Canonical link: https://commits.webkit.org/270474@main




More information about the webkit-changes mailing list