[webkit-changes] [WebKit/WebKit] 44519e: Do not promote WebRTC video conference web pages t...

youennf noreply at github.com
Thu Nov 9 09:54:05 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 44519e1f0b97a33fd1020f9c9909ea993ebb9e0d
      https://github.com/WebKit/WebKit/commit/44519e1f0b97a33fd1020f9c9909ea993ebb9e0d
  Author: Youenn Fablet <youennf at gmail.com>
  Date:   2023-11-09 (Thu, 09 Nov 2023)

  Changed paths:
    A LayoutTests/media/now-playing-status-for-video-conference-web-page-expected.txt
    A LayoutTests/media/now-playing-status-for-video-conference-web-page.html
    M LayoutTests/platform/mac-wk1/TestExpectations
    M Source/WebCore/html/MediaElementSession.cpp

  Log Message:
  -----------
  Do not promote WebRTC video conference web pages to NowPlaying
https://bugs.webkit.org/show_bug.cgi?id=264335
rdar://118057213

Reviewed by Eric Carlson.

When a web page becomes the NowPlaying app, it might receive Pause and Play commands.
This for instance happens when AirPods are removed from ears.
There are cases where the Pause command will be received but the Play command will not be sent when AirPods are back in ears.

Given video conference web pages currently do not handle well pause/play, we are, by default, no longer making web pages that do capture
and play several media streams the now playing app, except for web pages that use MediaSession since they are then responsible to handle play/pause commands.

* LayoutTests/media/now-playing-status-for-video-conference-web-page-expected.txt: Added.
* LayoutTests/media/now-playing-status-for-video-conference-web-page.html: Added.
* LayoutTests/platform/mac-wk1/TestExpectations:
* Source/WebCore/html/MediaElementSession.cpp:
(WebCore::isDocumentPlayingSeveralMediaStreamsAndCapturing):
(WebCore::processRemoteControlCommandIfPlayingMediaStreams):
(WebCore::MediaElementSession::nowPlayingInfo const):
(WebCore::isDocumentPlayingSeveralMediaStreams): Deleted.

Canonical link: https://commits.webkit.org/270459@main




More information about the webkit-changes mailing list