[webkit-changes] [WebKit/WebKit] b6917b: [iOS] Fix rendering of <select> in vertical writin...

Aditya Keerthi noreply at github.com
Thu Nov 9 09:03:21 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b6917b9c28b68740ab75cdf5b592623cc9ecf6ed
      https://github.com/WebKit/WebKit/commit/b6917b9c28b68740ab75cdf5b592623cc9ecf6ed
  Author: Aditya Keerthi <akeerthi at apple.com>
  Date:   2023-11-09 (Thu, 09 Nov 2023)

  Changed paths:
    M Source/WebCore/rendering/RenderThemeIOS.mm
    M Source/WebCore/rendering/style/RenderStyle.h
    M Source/WebCore/rendering/style/RenderStyleSetters.h

  Log Message:
  -----------
  [iOS] Fix rendering of <select> in vertical writing mode
https://bugs.webkit.org/show_bug.cgi?id=264441
rdar://118141664

Reviewed by Tim Nguyen.

Fix the position of the arrows in vertical writing mode, and ensure logical
properties are used instead of physical properties.

* Source/WebCore/rendering/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::adjustRoundBorderRadius):
(WebCore::applyCommonButtonPaddingToStyle):
(WebCore::RenderThemeIOS::adjustMenuListButtonStyle const):
(WebCore::RenderThemeIOS::adjustButtonStyle const):
(WebCore::RenderThemeIOS::paintMenuListButtonDecorationsWithFormControlRefresh):
* Source/WebCore/rendering/style/RenderStyle.h:
* Source/WebCore/rendering/style/RenderStyleSetters.h:
(WebCore::RenderStyle::setLogicalMinHeight):
(WebCore::RenderStyle::setLogicalMaxHeight):

Canonical link: https://commits.webkit.org/270453@main




More information about the webkit-changes mailing list