[webkit-changes] [WebKit/WebKit] 1a7f8f: [IFC] inline-block child preceded by an inline chi...

Alan Baradlay noreply at github.com
Thu Nov 9 05:32:16 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1a7f8f48b4c1cce252bbf8421f00b1420bec8fec
      https://github.com/WebKit/WebKit/commit/1a7f8f48b4c1cce252bbf8421f00b1420bec8fec
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-11-09 (Thu, 09 Nov 2023)

  Changed paths:
    A LayoutTests/fast/text/rtl-vertical-text-misalign-with-inline-blocks-expected.html
    A LayoutTests/fast/text/rtl-vertical-text-misalign-with-inline-blocks.html
    M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp
    M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.h

  Log Message:
  -----------
  [IFC] inline-block child preceded by an inline child has incorrect positioning in vertical writing modes with a right-to-left direction
https://bugs.webkit.org/show_bug.cgi?id=264425
<rdar://problem/118128181>

Reviewed by Antti Koivisto.

Turn (half)logical left to visual on BoxGeometry too.

* LayoutTests/fast/text/rtl-vertical-text-misalign-with-inline-blocks-expected.html: Added.
* LayoutTests/fast/text/rtl-vertical-text-misalign-with-inline-blocks.html: Added.
* Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:
(WebCore::Layout::InlineDisplayContentBuilder::adjustVisualGeometryForDisplayBox):
(WebCore::Layout::InlineDisplayContentBuilder::setLeftForWritingMode const):
* Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.h:

Canonical link: https://commits.webkit.org/270442@main




More information about the webkit-changes mailing list