[webkit-changes] [WebKit/WebKit] 71ef02: AirPods removed from ears should not disturb and o...

youennf noreply at github.com
Thu Nov 9 01:14:18 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 71ef02a300c45e9080fe75177c6c5a3dc18a0cd1
      https://github.com/WebKit/WebKit/commit/71ef02a300c45e9080fe75177c6c5a3dc18a0cd1
  Author: Youenn Fablet <youennf at gmail.com>
  Date:   2023-11-09 (Thu, 09 Nov 2023)

  Changed paths:
    M Source/WebCore/platform/mediastream/mac/BaseAudioSharedUnit.cpp
    M Source/WebCore/platform/mediastream/mac/BaseAudioSharedUnit.h
    M Source/WebCore/platform/mediastream/mac/CoreAudioSharedUnit.cpp
    M Source/WebCore/platform/mediastream/mac/CoreAudioSharedUnit.h

  Log Message:
  -----------
  AirPods removed from ears should not disturb and ongoing video call
https://bugs.webkit.org/show_bug.cgi?id=264334
rdar://116091083

Reviewed by Eric Carlson.

When AirPods are removed from ears, AirPods are disappearing from the list of existing devices.
Before the patch, it would trigger capture failure. But web pages do not handle well capture failure.
To help web pages, if capturing with the default microphone and the microphone is disappearing, we are now
migrating to the new default microphone.
We make sure to trigger a configurationchange event on the MediaStreamTrack, which exposes the change to the web page.

* Source/WebCore/platform/mediastream/mac/BaseAudioSharedUnit.cpp:
(WebCore::BaseAudioSharedUnit::setCaptureDevice):
(WebCore::BaseAudioSharedUnit::devicesChanged):
* Source/WebCore/platform/mediastream/mac/BaseAudioSharedUnit.h:
(WebCore::BaseAudioSharedUnit::migrateToNewDefaultDevice):
* Source/WebCore/platform/mediastream/mac/CoreAudioSharedUnit.cpp:
(WebCore::CoreAudioSharedUnit::migrateToNewDefaultDevice):
* Source/WebCore/platform/mediastream/mac/CoreAudioSharedUnit.h:

Canonical link: https://commits.webkit.org/270433@main




More information about the webkit-changes mailing list