[webkit-changes] [WebKit/WebKit] 059391: [WGSL] MSL compilation error opening https://webll...
Tadeu Zagallo
noreply at github.com
Thu Nov 9 00:46:00 PST 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 05939152b8cdf82e762d92acf17feeeb252caa1a
https://github.com/WebKit/WebKit/commit/05939152b8cdf82e762d92acf17feeeb252caa1a
Author: Tadeu Zagallo <tzagallo at apple.com>
Date: 2023-11-09 (Thu, 09 Nov 2023)
Changed paths:
M Source/WebGPU/WGSL/GlobalVariableRewriter.cpp
M Source/WebGPU/WGSL/tests/valid/packing.wgsl
Log Message:
-----------
[WGSL] MSL compilation error opening https://webllm.mlc.ai/ - 'global2' is not declared
https://bugs.webkit.org/show_bug.cgi?id=264373
rdar://118086159
Reviewed by Mike Wyrzykowski.
The GlobalVariableRewriter wasn't visiting the MemberAccessExpression's index, so
globals that were only used as indices were never marked as used.
* Source/WebGPU/WGSL/GlobalVariableRewriter.cpp:
(WGSL::RewriteGlobalVariables::getPacking):
* Source/WebGPU/WGSL/tests/valid/packing.wgsl:
Canonical link: https://commits.webkit.org/270431@main
More information about the webkit-changes
mailing list