[webkit-changes] [WebKit/WebKit] f514c3: LocalSampleBufferDisplayLayer does not need to rec...

youennf noreply at github.com
Thu Nov 9 00:03:22 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f514c3152b16a2818d7e3fd2af52d34e49858c8f
      https://github.com/WebKit/WebKit/commit/f514c3152b16a2818d7e3fd2af52d34e49858c8f
  Author: Youenn Fablet <youennf at gmail.com>
  Date:   2023-11-09 (Thu, 09 Nov 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.h
    M Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm

  Log Message:
  -----------
  LocalSampleBufferDisplayLayer does not need to recreate its AVSampleBufferDisplayLayer
https://bugs.webkit.org/show_bug.cgi?id=264251
rdar://117996669

Reviewed by Eric Carlson.

We did a workaround to speed up the rendering of MediaStreamTrack in case of size change.
The cost was a small flash as we were replacing one AVSBDL by another using replaceLayer.
We are removing this workaround which removes the small flash.
We still have issues with the temporary resizing that happens when the size changes.
This should be fixed as a follow-up.

* Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.h:
* Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm:
(WebCore::LocalSampleBufferDisplayLayer::initialize):
(WebCore::LocalSampleBufferDisplayLayer::updateSampleLayerBoundsAndPosition):
(WebCore::LocalSampleBufferDisplayLayer::flush):
(WebCore::LocalSampleBufferDisplayLayer::flushAndRemoveImage):
(WebCore::LocalSampleBufferDisplayLayer::enqueueVideoFrame):
(WebCore::LocalSampleBufferDisplayLayer::enqueueBufferInternal):
(WebCore::LocalSampleBufferDisplayLayer::clearVideoFrames):
(WebCore::LocalSampleBufferDisplayLayer::requestNotificationWhenReadyForVideoData):

Canonical link: https://commits.webkit.org/270426@main




More information about the webkit-changes mailing list