[webkit-changes] [WebKit/WebKit] e5bf2b: [iOS] Non-fullscreen content peeks into top safe a...

Jer Noble noreply at github.com
Wed Nov 8 23:24:06 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e5bf2b80f8e57e5186df3c301de3259c6e1e812c
      https://github.com/WebKit/WebKit/commit/e5bf2b80f8e57e5186df3c301de3259c6e1e812c
  Author: Jer Noble <jer.noble at apple.com>
  Date:   2023-11-08 (Wed, 08 Nov 2023)

  Changed paths:
    M Source/WebKit/UIProcess/API/ios/WKWebViewIOS.h
    M Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm
    M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm

  Log Message:
  -----------
  [iOS] Non-fullscreen content peeks into top safe area in element fullscreen mode
https://bugs.webkit.org/show_bug.cgi?id=264455
rdar://118147164

Reviewed by Simon Fraser.

When entering fullscreen, certain properties of the WKWebView and scrollView are reset to
default values, as clients like Safari may have overridden them. One of these properties,
contentInset, is reset to zero by that machinery. However, this causes overflow content to
be visible above the safe area; instead, it should be reset to a correct initial value that
accounts for the page's adoption of safe areas, via -_initialContentOffsetForScrollView.

* Source/WebKit/UIProcess/API/ios/WKWebViewIOS.h:
* Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:
(-[WKWebView _resetContentOffset]):
* Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:
(-[WKFullScreenWindowController enterFullScreen:]):

Canonical link: https://commits.webkit.org/270424@main




More information about the webkit-changes mailing list