[webkit-changes] [WebKit/WebKit] cee306: Stop doing a synchronous DecidePolicyForNavigation...

Chris Dumez noreply at github.com
Wed Nov 8 17:18:29 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cee30654e370a7b889acca916a7cba5fb3bd30fd
      https://github.com/WebKit/WebKit/commit/cee30654e370a7b889acca916a7cba5fb3bd30fd
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-11-08 (Wed, 08 Nov 2023)

  Changed paths:
    R LayoutTests/http/tests/navigation/fragment-navigation-policy-ignore-expected.txt
    R LayoutTests/http/tests/navigation/fragment-navigation-policy-ignore.html
    M Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.h
    M Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/StorageQuota.mm
    M Tools/TestWebKitAPI/cocoa/TestNavigationDelegate.h
    M Tools/TestWebKitAPI/cocoa/TestNavigationDelegate.mm

  Log Message:
  -----------
  Stop doing a synchronous DecidePolicyForNavigationAction IPC for fragment navigations
https://bugs.webkit.org/show_bug.cgi?id=262206
rdar://116480976

Reviewed by Alex Christensen.

Stop doing a synchronous DecidePolicyForNavigationAction IPC for fragment navigations.
We still call the client delegate (but asynchronously) and proceed with the navigation
synchronously, without waiting for the client decision. This is consistent with what
we did for empty document loads (about:blank). Navigation to fragments are not true
navigations and merely cause scrolling.

The behavior change is gated on a linked-on-after check to mitigate compatibility
risks.

* LayoutTests/http/tests/navigation/fragment-navigation-policy-ignore-expected.txt: Removed.
* LayoutTests/http/tests/navigation/fragment-navigation-policy-ignore.html: Removed.
* Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.h:
* Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

Canonical link: https://commits.webkit.org/270416@main




More information about the webkit-changes mailing list