[webkit-changes] [WebKit/WebKit] b08a0c: Make RenderLayer's RepaintStatus a enum class

Simon Fraser noreply at github.com
Wed Nov 8 16:25:59 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b08a0ce3562014798d15b108b650ae86128e9142
      https://github.com/WebKit/WebKit/commit/b08a0ce3562014798d15b108b650ae86128e9142
  Author: Simon Fraser <simon.fraser at apple.com>
  Date:   2023-11-08 (Wed, 08 Nov 2023)

  Changed paths:
    M Source/WebCore/rendering/RenderLayer.cpp
    M Source/WebCore/rendering/RenderLayer.h
    M Source/WebCore/rendering/RenderLayerModelObject.cpp
    M Source/WebCore/rendering/RenderObject.cpp

  Log Message:
  -----------
  Make RenderLayer's RepaintStatus a enum class
https://bugs.webkit.org/show_bug.cgi?id=264377
rdar://118092077

Reviewed by Alan Baradlay.

The `if (m_repaintStatus & NeedsFullRepaint)` was confusing and subtle; make it explicitly check
for both NeedsFullRepaint and NeedsFullRepaintForPositionedMovementLayout, and make the enum
an enum class.

We can also use an enum in the bitfield, and initialize it now.

* Source/WebCore/rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::removeOnlyThisLayer):
(WebCore::RenderLayer::recursiveUpdateLayerPositions):
(WebCore::RenderLayer::shouldRepaintAfterLayout const):
* Source/WebCore/rendering/RenderLayer.h:
(WebCore::RenderLayer::repaintStatus const):
(WebCore::RenderLayer::needsFullRepaint const):
* Source/WebCore/rendering/RenderLayerModelObject.cpp:
(WebCore::RenderLayerModelObject::styleDidChange):
* Source/WebCore/rendering/RenderObject.cpp:
(WebCore::RenderObject::setLayerNeedsFullRepaint):
(WebCore::RenderObject::setLayerNeedsFullRepaintForPositionedMovementLayout):

Canonical link: https://commits.webkit.org/270413@main




More information about the webkit-changes mailing list