[webkit-changes] [WebKit/WebKit] 5a5a27: Allowlist tests run in test-webkitpy-python2
Sam Sneddon
noreply at github.com
Wed Nov 8 14:54:51 PST 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5a5a272e649d8e37faba17f0124c86ab6072ed9a
https://github.com/WebKit/WebKit/commit/5a5a272e649d8e37faba17f0124c86ab6072ed9a
Author: Sam Sneddon <gsnedders at apple.com>
Date: 2023-11-08 (Wed, 08 Nov 2023)
Changed paths:
M Tools/Scripts/webkitpy/test/main.py
Log Message:
-----------
Allowlist tests run in test-webkitpy-python2
https://bugs.webkit.org/show_bug.cgi?id=264431
rdar://problem/118135522
Reviewed by Jonathan Bedard.
As we move towards a Python 3-only code base, we no longer need all of
our modules to run and be tested on Python 2. Instead, move to having an
allowlist of modules tested on Python 2, and expect every _other_ module
to fail to import with ImportError or SyntaxError. (This pedantically
only checks that the test module fails to import; it could be that the
test module fails to import but the actual implementation does
not. Hopefully that doesn't happen.)
* Tools/Scripts/webkitpy/test/main.py:
(main):
(Tester.__init__):
(Tester.expect_error_on_import):
(Tester._run_tests):
(Tester._check_imports):
Canonical link: https://commits.webkit.org/270408@main
More information about the webkit-changes
mailing list