[webkit-changes] [WebKit/WebKit] b2e2ad: Simplify PDFPlugin* access to Page

Tim Horton noreply at github.com
Wed Nov 8 11:57:35 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b2e2adf2a4fbb7526db06cb189e0941cf25ce701
      https://github.com/WebKit/WebKit/commit/b2e2adf2a4fbb7526db06cb189e0941cf25ce701
  Author: Tim Horton <thorton at apple.com>
  Date:   2023-11-08 (Wed, 08 Nov 2023)

  Changed paths:
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm

  Log Message:
  -----------
  Simplify PDFPlugin* access to Page
https://bugs.webkit.org/show_bug.cgi?id=264423
rdar://118127511

Reviewed by Chris Dumez.

* Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::hudEnabled const):
(WebKit::PDFPlugin::jsPDFDocPrint):
(WebKit::PDFPlugin::paintControlForLayerInContext):
(WebKit::PDFPlugin::convertFromPDFViewToScreen const):
(WebKit::PDFPlugin::boundsOnScreen const):
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h:
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm:
(WebKit::PDFPluginBase::page const):
(WebKit::PDFPluginBase::isActive const):
(WebKit::PDFPluginBase::forceUpdateScrollbarsOnMainThreadForPerformanceTesting const):
(WebKit::PDFPluginBase::deviceScaleFactor const):
(WebKit::PDFPluginBase::createScrollbar):
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::createGraphicsLayer):
(WebKit::UnifiedPDFPlugin::scheduleRenderingUpdate):
Add page() helper and adopt it in a bunch of places where we do a humorous
amount of work just to get to Page.

Canonical link: https://commits.webkit.org/270401@main




More information about the webkit-changes mailing list