[webkit-changes] [WebKit/WebKit] 30c2b2: [WebGPU] GPUCommandEncoder does not update the sta...

mwyrzykowski noreply at github.com
Wed Nov 8 04:37:45 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 30c2b2a3e5e50b051a3c23381fb5ea00c4614a9f
      https://github.com/WebKit/WebKit/commit/30c2b2a3e5e50b051a3c23381fb5ea00c4614a9f
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2023-11-08 (Wed, 08 Nov 2023)

  Changed paths:
    M Source/WebGPU/WebGPU/CommandEncoder.h
    M Source/WebGPU/WebGPU/CommandEncoder.mm
    M Source/WebGPU/WebGPU/ComputePassEncoder.h
    M Source/WebGPU/WebGPU/ComputePassEncoder.mm
    M Source/WebGPU/WebGPU/RenderPassEncoder.h
    M Source/WebGPU/WebGPU/RenderPassEncoder.mm

  Log Message:
  -----------
  [WebGPU] GPUCommandEncoder does not update the state of the encoder
https://bugs.webkit.org/show_bug.cgi?id=264363
rdar://117854010

Reviewed by Dan Glastonbury.

Validation was not working at submission time as the encoder state was
never changed from Open to Locked.

* Source/WebGPU/WebGPU/CommandEncoder.h:
* Source/WebGPU/WebGPU/CommandEncoder.mm:
(WebGPU::CommandEncoder::beginComputePass):
(WebGPU::CommandEncoder::beginRenderPass):
(WebGPU::CommandEncoder::lock):
* Source/WebGPU/WebGPU/ComputePassEncoder.h:
(WebGPU::ComputePassEncoder::create):
* Source/WebGPU/WebGPU/ComputePassEncoder.mm:
(WebGPU::ComputePassEncoder::ComputePassEncoder):
(WebGPU::ComputePassEncoder::endPass):
* Source/WebGPU/WebGPU/RenderPassEncoder.h:
(WebGPU::RenderPassEncoder::create):
* Source/WebGPU/WebGPU/RenderPassEncoder.mm:
(WebGPU::RenderPassEncoder::RenderPassEncoder):
(WebGPU::RenderPassEncoder::endPass):

Canonical link: https://commits.webkit.org/270383@main




More information about the webkit-changes mailing list