[webkit-changes] [WebKit/WebKit] c2381f: Generate IPC serialization for WebKit::PrintInfo

Žan Doberšek noreply at github.com
Wed Nov 8 00:30:18 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c2381fe366932db961b453199ca80d162f0e40a0
      https://github.com/WebKit/WebKit/commit/c2381fe366932db961b453199ca80d162f0e40a0
  Author: Žan Doberšek <zdobersek at igalia.com>
  Date:   2023-11-08 (Wed, 08 Nov 2023)

  Changed paths:
    M Source/WebKit/CMakeLists.txt
    M Source/WebKit/DerivedSources-input.xcfilelist
    M Source/WebKit/DerivedSources.make
    M Source/WebKit/Shared/PrintInfo.cpp
    M Source/WebKit/Shared/PrintInfo.h
    A Source/WebKit/Shared/PrintInfo.serialization.in
    M Source/WebKit/Shared/gtk/ArgumentCodersGtk.cpp
    M Source/WebKit/Shared/gtk/ArgumentCodersGtk.h
    M Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp
    M Source/WebKit/UIProcess/API/gtk/WebKitPrintOperation.cpp
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj
    M Source/WebKit/WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp
    M Source/WebKit/WebProcess/WebPage/gtk/WebPrintOperationGtk.h

  Log Message:
  -----------
  Generate IPC serialization for WebKit::PrintInfo
https://bugs.webkit.org/show_bug.cgi?id=264274

Reviewed by Michael Catanzaro.

Provide serialization input file for the WebKit::PrintInfo struct, removing the
need for custom encode/decode methods.

For the GTK port, the PrintMode enumeration is turned into the scoped equivalent
along with the necessary changes at points of use. ArgumentCoder specializations
are also provided for the two types that are GRefPtr-wrapped.

* Source/WebKit/CMakeLists.txt:
* Source/WebKit/Shared/PrintInfo.cpp:
(WebKit::PrintInfo::PrintInfo):
(WebKit::PrintInfo::encode const): Deleted.
(WebKit::PrintInfo::decode): Deleted.
* Source/WebKit/Shared/PrintInfo.h:
* Source/WebKit/Shared/PrintInfo.serialization.in: Added.
* Source/WebKit/Shared/gtk/ArgumentCodersGtk.cpp:
(IPC::ArgumentCoder<GRefPtr<GtkPrintSettings>>::encode):
(IPC::ArgumentCoder<GRefPtr<GtkPrintSettings>>::decode):
(IPC::ArgumentCoder<GRefPtr<GtkPageSetup>>::encode):
(IPC::ArgumentCoder<GRefPtr<GtkPageSetup>>::decode):
(IPC::encode): Deleted.
(IPC::decode): Deleted.
* Source/WebKit/Shared/gtk/ArgumentCodersGtk.h:
* Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:
(webkitWebViewPrintFrame):
* Source/WebKit/UIProcess/API/gtk/WebKitPrintOperation.cpp:
(webkitPrintOperationPrintPagesForFrame):
* Source/WebKit/WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:
(WebKit::WebPrintOperationGtk::PrintPagesData::PrintPagesData):
(WebKit::WebPrintOperationGtk::print):
* Source/WebKit/WebProcess/WebPage/gtk/WebPrintOperationGtk.h:

Canonical link: https://commits.webkit.org/270377@main




More information about the webkit-changes mailing list