[webkit-changes] [WebKit/WebKit] 0c99f2: Move setView() to the RemoteFrame constructor

Charlie Wolfe noreply at github.com
Tue Nov 7 20:27:02 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0c99f26c7129369b8bfd9df079d40f44274b8839
      https://github.com/WebKit/WebKit/commit/0c99f26c7129369b8bfd9df079d40f44274b8839
  Author: Charlie Wolfe <charliew at apple.com>
  Date:   2023-11-07 (Tue, 07 Nov 2023)

  Changed paths:
    M Source/WebCore/page/RemoteFrame.cpp
    M Source/WebKit/WebProcess/WebPage/WebFrame.cpp

  Log Message:
  -----------
  Move setView() to the RemoteFrame constructor
https://bugs.webkit.org/show_bug.cgi?id=264376
rdar://118089394

Reviewed by Alex Christensen.

There are currently some situations where a RemoteFrame can exist without a RemoteFrameView. We should
move the setView() call to the RemoteFrame constructor so this can't happen.

* Source/WebCore/page/RemoteFrame.cpp:
(WebCore::m_layerHostingContextIdentifier):
* Source/WebKit/WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::didCommitLoadInAnotherProcess):

Canonical link: https://commits.webkit.org/270367@main




More information about the webkit-changes mailing list