[webkit-changes] [WebKit/WebKit] a96553: [WebGPU] Queue::commitMTLCommandBuffer will fail i...

mwyrzykowski noreply at github.com
Tue Nov 7 17:37:35 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a965533e01fa734237987cad947b3ef7c651f0c7
      https://github.com/WebKit/WebKit/commit/a965533e01fa734237987cad947b3ef7c651f0c7
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2023-11-07 (Tue, 07 Nov 2023)

  Changed paths:
    M Source/WebGPU/WebGPU/CommandBuffer.h
    M Source/WebGPU/WebGPU/CommandBuffer.mm
    M Source/WebGPU/WebGPU/Queue.h
    M Source/WebGPU/WebGPU/Queue.mm

  Log Message:
  -----------
  [WebGPU] Queue::commitMTLCommandBuffer will fail if command buffer was already committed
https://bugs.webkit.org/show_bug.cgi?id=264339
<radar://117851924>

Reviewed by Tadeu Zagallo.

Ensure that a command buffer doesn't get submitted twice and generate
a validation error if we would attempt to do so.

* Source/WebGPU/WebGPU/CommandBuffer.h:
* Source/WebGPU/WebGPU/CommandBuffer.mm:
(WebGPU::CommandBuffer::makeInvalid):
* Source/WebGPU/WebGPU/Queue.h:
* Source/WebGPU/WebGPU/Queue.mm:
(WebGPU::Queue::validateSubmit const):
(WebGPU::Queue::commitMTLCommandBuffer):
(WebGPU::Queue::submit):
(wgpuQueueSubmit):

Canonical link: https://commits.webkit.org/270361@main




More information about the webkit-changes mailing list