[webkit-changes] [WebKit/WebKit] f5d367: [JSC] Use simpler helpers for repatching

Yusuke Suzuki noreply at github.com
Tue Nov 7 13:48:59 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f5d367e64491c2ee7cc87a3b9d9b849d387a5f43
      https://github.com/WebKit/WebKit/commit/f5d367e64491c2ee7cc87a3b9d9b849d387a5f43
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2023-11-07 (Tue, 07 Nov 2023)

  Changed paths:
    M Source/JavaScriptCore/assembler/ARM64Assembler.h
    M Source/JavaScriptCore/assembler/ARMv7Assembler.h
    M Source/JavaScriptCore/assembler/MacroAssemblerARM64.h
    M Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h
    M Source/JavaScriptCore/assembler/MacroAssemblerRISCV64.h
    M Source/JavaScriptCore/assembler/MacroAssemblerX86Common.h
    M Source/JavaScriptCore/assembler/RISCV64Assembler.h
    M Source/JavaScriptCore/assembler/X86Assembler.h
    M Source/JavaScriptCore/bytecode/CallLinkInfo.cpp
    M Source/JavaScriptCore/bytecode/InlineAccess.cpp

  Log Message:
  -----------
  [JSC] Use simpler helpers for repatching
https://bugs.webkit.org/show_bug.cgi?id=264299
rdar://118023749

Reviewed by Michael Saboff.

Repatching is typically just emitting very specific known sequence. This patch uses existing
simpler repatch helpers instead of full-fledged CCallHelpers::emitJITCodeOver.

* Source/JavaScriptCore/assembler/ARM64Assembler.h:
* Source/JavaScriptCore/assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::replaceWithNops):
* Source/JavaScriptCore/assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::replaceWithNops):
* Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::replaceWithNops):
* Source/JavaScriptCore/assembler/MacroAssemblerRISCV64.h:
(JSC::MacroAssemblerRISCV64::replaceWithNops):
* Source/JavaScriptCore/assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::replaceWithNops):
* Source/JavaScriptCore/assembler/RISCV64Assembler.h:
(JSC::RISCV64Assembler::replaceWithNops):
* Source/JavaScriptCore/assembler/X86Assembler.h:
(JSC::X86Assembler::replaceWithNops):
* Source/JavaScriptCore/bytecode/CallLinkInfo.cpp:
(JSC::OptimizingCallLinkInfo::initializeDirectCall):
(JSC::OptimizingCallLinkInfo::setDirectCallTarget):
* Source/JavaScriptCore/bytecode/InlineAccess.cpp:
(JSC::InlineAccess::rewireStubAsJumpInAccess):

Canonical link: https://commits.webkit.org/270351@main




More information about the webkit-changes mailing list